Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libredirect: Add preload wrapper for stat() #50267

Closed
wants to merge 1 commit into from
Closed

libredirect: Add preload wrapper for stat() #50267

wants to merge 1 commit into from

Conversation

aszlig
Copy link
Member

@aszlig aszlig commented Nov 12, 2018 •
edited

DO NOT EVER MERGE THIS

It's only for testing libredirect with ofborg on Darwin as I don't have a Darwin machine.

@aszlig
libredirect: Add preload wrapper for stat()
488cb85 
Pull request NixOS#50246 was merged a bit too quickly and it was supposed to
fix libredirect on Darwin. However it still fails on Darwin because I
was using ofborg to check Darwin builds as I don't have Apple hardware.

Providing a symbol for stat shouldn't hurt on GNU/Linux but might work
on Darwin, because it probably doesn't have __xstat*() but might have a
stat() symbol.

Signed-off-by: aszlig <aszlig@nix.build>
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libredirect

Partial log (click to expand)

'libredirect.so' -> '/nix/store/by7v7vghrs0qk4wbcqmh0rsycw8dvbpj-libredirect-0/lib/libredirect.so'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/by7v7vghrs0qk4wbcqmh0rsycw8dvbpj-libredirect-0
shrinking /nix/store/by7v7vghrs0qk4wbcqmh0rsycw8dvbpj-libredirect-0/lib/libredirect.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/by7v7vghrs0qk4wbcqmh0rsycw8dvbpj-libredirect-0/lib
patching script interpreter paths in /nix/store/by7v7vghrs0qk4wbcqmh0rsycw8dvbpj-libredirect-0
checking for references to /build in /nix/store/by7v7vghrs0qk4wbcqmh0rsycw8dvbpj-libredirect-0...
running install tests
/nix/store/by7v7vghrs0qk4wbcqmh0rsycw8dvbpj-libredirect-0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libredirect

Partial log (click to expand)

installing
install: creating directory '/nix/store/828lrnr37riwy9i2pfgnp44b2kl43d2q-libredirect-0'
install: creating directory '/nix/store/828lrnr37riwy9i2pfgnp44b2kl43d2q-libredirect-0/lib'
'libredirect.dylib' -> '/nix/store/828lrnr37riwy9i2pfgnp44b2kl43d2q-libredirect-0/lib/libredirect.dylib'
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/828lrnr37riwy9i2pfgnp44b2kl43d2q-libredirect-0/lib
patching script interpreter paths in /nix/store/828lrnr37riwy9i2pfgnp44b2kl43d2q-libredirect-0
running install tests
/nix/store/828lrnr37riwy9i2pfgnp44b2kl43d2q-libredirect-0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libredirect

Partial log (click to expand)

'libredirect.so' -> '/nix/store/4bymfdk8a65xcdca17lfm9hxic03ibn1-libredirect-0/lib/libredirect.so'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4bymfdk8a65xcdca17lfm9hxic03ibn1-libredirect-0
shrinking /nix/store/4bymfdk8a65xcdca17lfm9hxic03ibn1-libredirect-0/lib/libredirect.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4bymfdk8a65xcdca17lfm9hxic03ibn1-libredirect-0/lib
patching script interpreter paths in /nix/store/4bymfdk8a65xcdca17lfm9hxic03ibn1-libredirect-0
checking for references to /build in /nix/store/4bymfdk8a65xcdca17lfm9hxic03ibn1-libredirect-0...
running install tests
/nix/store/4bymfdk8a65xcdca17lfm9hxic03ibn1-libredirect-0

@aszlig
Copy link
Member Author

aszlig commented Nov 12, 2018

No longer needed: a815f53

@aszlig aszlig closed this Nov 12, 2018
@aszlig aszlig deleted the xxx-darwin-test branch November 12, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aszlig @GrahamcOfBorg