Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scikitlearn: 0.19.2 -> 0.20.0 #50266

Merged
merged 2 commits into from Nov 13, 2018
Merged

scikitlearn: 0.19.2 -> 0.20.0 #50266

merged 2 commits into from Nov 13, 2018

Conversation

kwohlfahrt
Copy link
Contributor

Re-enable tests, as upstream now uses pytest and it works.

Motivation for this change

I needed the output_dict option for sklearn.metrics.classification_report

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kwohlfahrt
scikitlearn: 0.19.2 -> 0.20.0
35352ed 
Also re-enable tests
@FRidh FRidh self-assigned this Nov 12, 2018
@costrouc
Copy link
Member

@GrahamcOfBorg build python27Packages.scikitlearn python36Packages.scikitlearn

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python27Packages.scikitlearn, python36Packages.scikitlearn

Partial log (click to expand)

    np.sum(class_probability_nz))

sklearn/utils/tests/test_validation.py::test_as_float_array_nan[X1]
  /nix/store/ykbc8jhy5dcsjxk2i780jn4gcypjxqr9-python2.7-scipy-1.1.0/lib/python2.7/site-packages/scipy/sparse/compressed.py:746: SparseEfficiencyWarning: Changing the sparsity structure of a csr_matrix is expensive. lil_matrix is more efficient.
    SparseEfficiencyWarning)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 3 failed, 9909 passed, 109 skipped, 1 deselected, 1 xfailed, 174 warnings in 868.84 seconds
builder for '/nix/store/vqmilya8y4bm7li7q8dran5bd6vrps6g-python2.7-scikit-learn-0.20.0.drv' failed with exit code 1
error: build of '/nix/store/cr84z1cqjsdxwkyab6pk5lnmxdfk9gds-python3.6-scikit-learn-0.20.0.drv', '/nix/store/vqmilya8y4bm7li7q8dran5bd6vrps6g-python2.7-scikit-learn-0.20.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.scikitlearn, python36Packages.scikitlearn

Partial log (click to expand)

  /nix/store/zpn0d1gizyrr66dgmx7c5wm5sh3b6x0d-python2.7-scikit-learn-0.20.0/lib/python2.7/site-packages/sklearn/utils/random.py:191: RuntimeWarning: invalid value encountered in true_divide
    np.sum(class_probability_nz))

sklearn/utils/tests/test_validation.py::test_as_float_array_nan[X1]
  /nix/store/sk8pfrw51m3586zwzzqxqjvpi4zhhshh-python2.7-scipy-1.1.0/lib/python2.7/site-packages/scipy/sparse/compressed.py:746: SparseEfficiencyWarning: Changing the sparsity structure of a csr_matrix is expensive. lil_matrix is more efficient.
    SparseEfficiencyWarning)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 9912 passed, 109 skipped, 1 deselected, 1 xfailed, 175 warnings in 1386.22 seconds
pytestcachePhase

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

Looks like some numerical edge cases again that only trigger bugs on aarch64. I would suggest to just disable testing on that platform.

@kwohlfahrt
Copy link
Contributor Author

Tests disabled on aarch64. Do I have permissions to run Graham?

@GrahamcOfBorg build python27Packages.scikitlearn python36Packages.scikitlearn

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

@GrahamcOfBorg build python27Packages.scikitlearn python36Packages.scikitlearn

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.scikitlearn, python36Packages.scikitlearn

Partial log (click to expand)

shrinking /nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0/lib/python2.7/site-packages/sklearn/utils/seq_dataset.so
shrinking /nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0/lib/python2.7/site-packages/sklearn/utils/sparsefuncs_fast.so
shrinking /nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0/lib/python2.7/site-packages/sklearn/utils/weight_vector.so
shrinking /nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0/lib/python2.7/site-packages/sklearn/_isotonic.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0/lib
patching script interpreter paths in /nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0
checking for references to /build in /nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0...
/nix/store/x4zl2ld2z7q21bl47nm709hcrhaflyr7-python2.7-scikit-learn-0.20.0
/nix/store/jl4gy59d8ay967hnkqgl3vqdk37ip7v7-python3.6-scikit-learn-0.20.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.scikitlearn, python36Packages.scikitlearn

Partial log (click to expand)

  /nix/store/2v57y8gcygfv7707105jbv3byfwg034p-python2.7-scikit-learn-0.20.0/lib/python2.7/site-packages/sklearn/utils/random.py:191: RuntimeWarning: invalid value encountered in true_divide
    np.sum(class_probability_nz))

sklearn/utils/tests/test_validation.py::test_as_float_array_nan[X1]
  /nix/store/3wbvciii4zj10rq055rf7v9f72vmayvx-python2.7-scipy-1.1.0/lib/python2.7/site-packages/scipy/sparse/compressed.py:746: SparseEfficiencyWarning: Changing the sparsity structure of a csr_matrix is expensive. lil_matrix is more efficient.
    SparseEfficiencyWarning)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 9905 passed, 114 skipped, 1 deselected, 3 xfailed, 175 warnings in 356.28 seconds
pytestcachePhase

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.scikitlearn, python36Packages.scikitlearn

Partial log (click to expand)

  /nix/store/z8gm32jimb1348n3qrgpxglmk3rn634s-python3.6-scipy-1.1.0/lib/python3.6/site-packages/scipy/sparse/compressed.py:746: SparseEfficiencyWarning: Changing the sparsity structure of a csr_matrix is expensive. lil_matrix is more efficient.
    SparseEfficiencyWarning)

sklearn/utils/tests/test_validation.py::test_check_array_force_all_finiteinvalid[csr_matrix-nan-1-Input contains NaN, infinity]
  /nix/store/z8gm32jimb1348n3qrgpxglmk3rn634s-python3.6-scipy-1.1.0/lib/python3.6/site-packages/scipy/sparse/compressed.py:746: SparseEfficiencyWarning: Changing the sparsity structure of a csr_matrix is expensive. lil_matrix is more efficient.
    SparseEfficiencyWarning)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 9914 passed, 107 skipped, 1 deselected, 1 xfailed, 948 warnings in 379.21 seconds
pytestcachePhase

@FRidh FRidh merged commit da65cfc into NixOS:master Nov 13, 2018
@kwohlfahrt kwohlfahrt deleted the scikitlearn branch December 7, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc costrouc approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kwohlfahrt @costrouc @GrahamcOfBorg @Mic92 @roberth @FRidh