sonota: init at 2018-10-07 #50257
Merged
sonota: init at 2018-10-07 #50257
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
8.has: package (new)
|
Success on x86_64-linux (full log) Attempted: sonota Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: sonota Partial log (click to expand)
|
pkgs/tools/misc/sonota/default.nix
Outdated
| sha256 = "0jd9xrhcyk8d2plbjnrlpn87536zr6n708797n0k5blf109q3c1z"; | ||
| }; | ||
|
|
||
| patches = [ ./set_resource_path.patch ]; |
There was a problem hiding this comment.
Couldn't this and the 'postPatch' be simplified with substituteAll?
patches = [
(substituteAll {
src = ./set_resource_path.patch;
out = "$out";
})
];
There was a problem hiding this comment.
Almost, we need out = placeholder "out";. Thanks for the tip!
There was a problem hiding this comment.
Darn, forgot that placeholder doesn't work for substituteAll NixOS/nix#1846
So instead you'll have to do
postPatch = ''
substituteInPlace sonota.py --subst-var out
'';
with the plain patch.
There was a problem hiding this comment.
But it works though. This is the output:
def resource_path(relative_path):
return os.path.join("/nix/store/9x9ahhb32yg2i4izxz9f250yi9vsc61n-set_resource_path.patch/share/sonota", relative_path)
There was a problem hiding this comment.
But see that out is the patch /nix/store/9x9ahhb32yg2i4izxz9f250yi9vsc61n-set_resource_path.patch?
GrahamcOfBorg
added
the
11.by: package-maintainer
|
The date should also be the same as the one in the derivation name. |
worldofpeace
approved these changes
Feb 7, 2019
|
Thanks @worldofpeace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is super useful for doing what is essentially a MITM attack on Sonoff devices in order to do OTA upgrades to open source firmware.
Tried it out successfully on a few different devices (S20, T1-1, T1-3). Doesn't work with the B1 though.
Cc: @fpletz
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)