Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sepaxml & fints #52486

Merged
merged 0 commits into from Dec 20, 2018
Merged

add sepaxml & fints #52486

merged 0 commits into from Dec 20, 2018

Conversation

elohmeier
Copy link
Contributor

@elohmeier elohmeier commented Dec 18, 2018 •
edited

Motivation for this change

python modules sepaxml & fints missing in nixpkgs

Things done

added the modules

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda requested changes Dec 18, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get rid of the merge commit and add a pythonPackages. prefix to the commit messages.

pkgs/development/python-modules/fints/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/fints/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sepaxml/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sepaxml/default.nix Outdated Show resolved Hide resolved
dotlambda
dotlambda requested changes Dec 18, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these packages python3-only? In that case, please add disabled = !isPy3k.

@elohmeier
Copy link
Contributor Author

@dotlambda thanks for your feedback! I've updated the pull request.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.fints

1 similar comment
@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.fints

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or set doCheck = false and add a comment with the reason.

@dotlambda
Copy link
Member

Also, did you even test the package? It seems like mt-940 does not build on your branch. Please rebase on master.

@elohmeier elohmeier closed this Dec 20, 2018
@Mic92 Mic92 merged commit 8a3ad1c into NixOS:master Dec 20, 2018
@elohmeier elohmeier mentioned this pull request Dec 20, 2018
Merged
10 tasks
@elohmeier
Copy link
Contributor Author

I've added the doCheck options and also disabled them in mt-940. (I've had them disabled there locally before)

@elohmeier
Copy link
Contributor Author

There is a new PR #52578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elohmeier @dotlambda @Mic92 @GrahamcOfBorg @Janik-Haag