Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/oh-my-zsh: fix wrong manual information #52485

Merged
merged 1 commit into from Dec 18, 2018
Merged

nixos/oh-my-zsh: fix wrong manual information #52485

merged 1 commit into from Dec 18, 2018

Conversation

pablode
Copy link
Contributor

@pablode pablode commented Dec 18, 2018

Motivation for this change

The manual still refers to 'programs.ohMyZsh' although it should be 'programs.zsh.ohMyZsh' [1] [2].
We change this, because we want to provide correct information to users reading the manual.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pablode
nixos/oh-my-zsh: fix wrong manual information
685c4f5 
Manual still refers to 'programs.ohMyZsh' although it should be 'programs.zsh.ohMyZsh'.
@Ma27
Copy link
Member

Ma27 commented Dec 18, 2018

ouch, thanks a lot for noticing and fixing that! :)

@Ma27 Ma27 merged commit 83fe20e into NixOS:master Dec 18, 2018
@Ma27
Copy link
Member

Ma27 commented Dec 18, 2018

also backported as 5fe7934.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablode @Ma27 @GrahamcOfBorg @Janik-Haag