Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-google-auth: use python36 (#52445) #52470

Closed
wants to merge 2 commits into from
Closed

aws-google-auth: use python36 (#52445) #52470

wants to merge 2 commits into from

Conversation

memberbetty
Copy link
Contributor

Motivation for this change

Fix #52445.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam requested changes Dec 18, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@marsam @memberbetty
aws-google-auth: use python3 (NixOS#52445)
681ec53 
Co-Authored-By: memberbetty <45791182+memberbetty@users.noreply.github.com>
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build aws-google-auth

@worldofpeace
Copy link
Contributor

worldofpeace commented Dec 18, 2018 •
edited

What's happening here is that keyring wants secretstorage 2.x.x when python is older than 3.5.
python 3.5 is a requirement for secretstorage 3.x.x.

Since we can't mix another version of secretstorage into nixpkgs, this is the appropriate fix 👍

@worldofpeace
Copy link
Contributor

Merged in d268e3b

@memberbetty Thanks ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-google-auth: secretstorage-3.1.0 not supported for interpreter python2.7
5 participants
@memberbetty @worldofpeace @marsam @GrahamcOfBorg @Janik-Haag