-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still, Too slow warp speed in MacOS #1955
Comments
Added support for benchmarking on Linux and macOS in #1960 and #1961.
On Linux:
On macOS:
One of these is not like the others. (Edited on 2018-11-12 to use the optimized numbers, not the debug numbers for macOS.) |
The benchmark in #1962 shows clear problems with I am not sure how to fix this: it seems intrinsic to macOS, and we are not going to come up with our own mutex implementation. One possibility would be to use |
It appears there may be a way to make macOS mutexes unfair? From this Mozilla blog:
The author saw a roughly order of magnitude increase in a lock fairness benchmark ported from Webkit to use raw pthreads on macOS 10.10.5 on a Mac mini. I don't know what libc++ uses for |
After #1978, the (optimized) numbers for macOS are as follow:
Compare this with the macOS numbers above: we have 3 vessels; for 1 and 2 threads in the pool, the elapsed times are the same because there is no contention; for 3 threads or more, the native macOS mutex goes into contention and fairness madness, whereas the The change will be in Erdős, to be released around December 7th. I am closing this bug. Please comment once Erdős is released on the performance gain (or not). |
Erdős is now available. When you have a chance, please tell us how the performance looks on macOS (our mac is a rather weak machine, so it's a bit hard to tell). |
@pleroy I've been testing Erdos on my MacBook Pro 13' for 3 days, now, even with this machine, I can get up to 30 fps, and it basically didn't have much impact on CPU compares to not installing Principia. Because I am not at home currently, so I can't tell the difference between MacOS and Windows, but current testing indicates a very good result, after I come home, I would test on the same machine I used on earlier tests. |
Thanks for the info @EthanWang706. Looking forward to hearing about the performance on your home machine. |
Principia Version: Descartes
MacOS Version: 10.13.6
KSP Version: 1.3.1
It has about 30-50% improvement after last update, but still, with only 3 spacecraft, RSS+RO+16K texture, I can only get 7 fps on KSC page with no time warping, before the update, it's 4-5fps. Warping to 10,000x is the maximum speed you can get without getting less than 1fps. In Windows 10, the same computer, same GameData, same KSP version, it could reach as high fps as I set in setting.
The text was updated successfully, but these errors were encountered: