New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdfmod module #52484
Pdfmod module #52484
Conversation
It is a responsibility of your desktop environment to enable GConf database, if you want to support legacy programs. Adding a module for each legacy program is too clutter-some, I would suggest introducing Bumping the mono version is fine with me, though the requirement is weird – pdfmod is dead package after all. |
@jtojnar I wouldn't quite put it like that. How should my desktop environment know that this one specific gtk program needs gconf? Especially for the newbie user, they'd just see that installing a specific package resulted in a runtime error every time they wanted open a file with it. And introducing a "hidden" feature like pdfmod being a dead package is certainly a valid point, however. In the interest of keeping nixpkgs relatively clean of such packages, maybe we should instead just completely remove it? |
Can I suggest that we neither create a dummy NixOS module, nor drop the package from nixpkgs? At the moment, the package produces a runtime error when GConf is missing. That's not ideal but probably better than the two choices above. |
Re mono version, maybe let's just drop the override and go with the 'default' mono version since it's probably supported? The fewer overrides, the fewer versions of mono users need to download (and we need to maintain). |
mono 5.8 is the current default and that one still contains the magic number error on non-xterm terminals as mentioned above. Only mono versions >= 5.10, of which we package 5.14 as the latest stable release, contain that fix. I've changed the PR accordingly and excluded the dummy module again. |
Could you please merge with #52712 ? |
Motivation for this change
Change to new mono version due to mono/mono#6752 (mono 5.8 is the default, and it still fails with that, mono 5.10 should work, but as long as it builds with 5.14, I though why not go with that). Also pdfmod has always needed gconf to be installed as well, so I've included a stupid little module which just installs both packages together -- unsure how else to solve this otherwise.
/cc @obadz
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)