Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix the part of the float test that requires IEC559/IEEE754 compliance
GCC and CLang compilers fail to support full IEC559 compliance required for the test, when certain compiler flags are active. This patch implements a heuristic that checks for the most common flag in GCC and CLang, plues an extra check which GCC disables when it's not compliant, to hopefully catch most cases where it can't run.
  • Loading branch information
Pedro Gimeno authored and nerzhul committed Dec 18, 2018
1 parent 7a4d4bc commit 8e4095f
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/unittest/test_serialization.cpp
Expand Up @@ -674,6 +674,19 @@ void TestSerialization::testFloatFormat()
return;
}

// The code below compares the IEEE conversion functions with a
// known good IEC559/IEEE754 implementation. This test neeeds
// IEC559 compliance in the compiler.
#if defined(__GNUC__) && (!defined(__STDC_IEC_559__) || defined(__FAST_MATH__))
// GNU C++ lies about its IEC559 support when -ffast-math is active.
// https://gcc.gnu.org/bugzilla//show_bug.cgi?id=84949
bool is_iec559 = false;
#else
bool is_iec559 = std::numeric_limits<f32>::is_iec559;
#endif
if (!is_iec559)
return;

auto test_single = [&fs, &fm](const u32 &i) -> bool {
memcpy(&fm, &i, 4);
fs = u32Tof32Slow(i);
Expand Down

0 comments on commit 8e4095f

Please sign in to comment.