Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotop: 1.5.0 -> 1.7.1 #52476

Merged
merged 1 commit into from Dec 18, 2018
Merged

gotop: 1.5.0 -> 1.7.1 #52476

merged 1 commit into from Dec 18, 2018

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Dec 18, 2018

Motivation for this change

main motivation: having it up to date.

side-question: is someone aware of a go modules to deps.nix method? I used go2nix but I don't think this consults go.mod yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rasendubi
Copy link
Member

@GrahamcOfBorg build gotop

rasendubi
rasendubi approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally—works fine

@rasendubi rasendubi merged commit d3e79e6 into NixOS:master Dec 18, 2018
@cryptix cryptix deleted the update/gotop branch December 19, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cryptix @rasendubi @GrahamcOfBorg