freetype: 2.9 -> 2.9.1 #52493
freetype: 2.9 -> 2.9.1 #52493
Conversation
freetype-config deprecated, manually enabled with new configureFlag closes NixOS#52415
| @@ -49,7 +49,7 @@ in stdenv.mkDerivation rec { | |||
|
|
|||
| outputs = [ "out" "dev" ]; | |||
|
|
|||
| configureFlags = [ "--disable-static" "--bindir=$(dev)/bin" ]; | |||
| configureFlags = [ "--disable-static" "--bindir=$(dev)/bin" "--enable-freetype-config" ]; | |||
There was a problem hiding this comment.
It looks like freetype's build system is also installing a pkg-config file, and I assume that if freetype-config is going away, downstream packages should be checking for freetype via pkg-config? How many packages in nixpkgs currently depend on freetype-config? Should there be issues created to track or fix those, or a comment here so we know when to remove this flag?
There was a problem hiding this comment.
@endgame everything you said seems correct. i'm not sure now to track what packages currently use freetype-config other than testings all dependencies without including the binary and seeing what breaks
There was a problem hiding this comment.
Maybe make a branch that's the version bump with no configure argument, and get someone to point hydra at it? I don't know who the correct person is, so I'm going to take a stab and ping @grahamc since ofborg has his name on things.
@grahamc hopefully you can add the right people and then unsub yourself. If my guess was wildly out-of-line, then I'm sorry.
|
FYI, 2.9 is breaking PDF rendering (in e.g. mupdf-x11, Okular) for some PDFs, so this is kind of high-priority. 2.9.1 confirmed to fix. Examples: https://i.imgur.com/PojSxTV.png |
|
closing since #52524 was merged |
freetype-configdeprecated, manually enabled with newconfigureFlagsee http://lists.nongnu.org/archive/html/freetype-announce/2018-05/msg00000.html
Motivation for this change
closes #52415
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)