Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oxidized: 0.21.0 -> 0.25.0, drop obsolete patch #52492

Merged
merged 1 commit into from Dec 18, 2018
Merged

oxidized: 0.21.0 -> 0.25.0, drop obsolete patch #52492

merged 1 commit into from Dec 18, 2018

Conversation

WilliButz
Copy link
Member

This updates oxidized to its latest version and removes the patch for Dell X-series support because
oxidized now includes a seperate model for these switches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Tested functionality with various switch models :)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
oxidized: 0.21.0 -> 0.25.0, drop obsolete patch
60413b4 
This removes the patch for support of Dell X-series because
oxidized now includes a model for these switches.
@zimbatm zimbatm merged commit 9b2e8dd into NixOS:master Dec 18, 2018
@WilliButz WilliButz deleted the update-oxidized branch December 19, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @zimbatm @GrahamcOfBorg