Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favor HTTPS URLs - the GNU edition #51329

Merged
merged 4 commits into from Dec 2, 2018
Merged

Favor HTTPS URLs - the GNU edition #51329

merged 4 commits into from Dec 2, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 1, 2018

Motivation for this change

GNU / Savannah / NonGNU domains always offers HTTPS and often there is even a redirect from plain http to https. So let's save a redirect to users (and Hydra) when following a link to an homepage or to a source tarball. It also updates links in the doc.
More details in the commit messages.

+ a bonus on a small number of SourceForge URLs that were left before

Related: #13809 / #50989
/cc @markuskowa @infinisil @ryantm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

I guess the mass rebuild is caused by changing the URLs in the some of the patches. If you want to keep that it should maybe go in to staging.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 1, 2018

No the point is not to trigger a mass-rebuild. I'll undo the changes on patches, it's not necessary and not the important part.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 2, 2018

There! Now we have something practical to work with.
(sorry for the noise)

@markuskowa markuskowa merged commit 506d4c7 into NixOS:master Dec 2, 2018
@c0bw3b c0bw3b deleted the cleanup/gnu-https branch December 6, 2018 20:06
@infinisil infinisil mentioned this pull request Apr 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @markuskowa @GrahamcOfBorg