Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdb: switch to python3 #51315

Merged
merged 8 commits into from Dec 2, 2018
Merged

gdb: switch to python3 #51315

merged 8 commits into from Dec 2, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 1, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner December 1, 2018 14:14
@Mic92
Copy link
Member Author

Mic92 commented Dec 1, 2018

cc @schmittlauch

@Mic92 Mic92 merged commit 330ab9b into NixOS:staging Dec 2, 2018
@Mic92 Mic92 deleted the python3-gdb branch December 2, 2018 11:09
@orivej
Copy link
Contributor

orivej commented Dec 4, 2018

I was surprised to discover that the scripts that I use are already compatible with python3: this used to be a problem in the past. I would have added python2 variants of the affected packages if this were not the case, because python2 seems more suitable for scripting gdb with its string literals being byte strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @orivej @GrahamcOfBorg