Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 357439aeac07
Choose a base ref
...
head repository: NixOS/ofborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7274cc2b5e12
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 30, 2018

  1. Relocate a TimedOut error to a Cancelled error to avoid red X's

    @grahamc
    grahamc committed Nov 30, 2018
    Copy the full SHA
    7274cc2 View commit details
Showing with 8 additions and 3 deletions.
  1. +8 −3 ofborg/src/tasks/githubcommentposter.rs
11 changes: 8 additions & 3 deletions ofborg/src/tasks/githubcommentposter.rs
View file
Original file line number Diff line number Diff line change
@@ -92,7 +92,7 @@ fn result_to_check(result: &LegacyBuildResult) -> CheckRunOptions {
BuildStatus::Skipped => Conclusion::Cancelled,
BuildStatus::Success => Conclusion::Success,
BuildStatus::Failure => Conclusion::Neutral,
BuildStatus::TimedOut => Conclusion::TimedOut,
BuildStatus::TimedOut => Conclusion::Cancelled,
BuildStatus::UnexpectedError { err: _ } => Conclusion::Neutral,
};

@@ -101,6 +101,10 @@ fn result_to_check(result: &LegacyBuildResult) -> CheckRunOptions {
summary.extend(list_segment("Attempted", attempted.clone()));
}

if result.status == BuildStatus::TimedOut {
summary.push(String::from("Build timed out."));
}

if let Some(ref skipped) = result.skipped_attrs {
summary.extend(list_segment(
&format!(
@@ -805,14 +809,15 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
started_at: None,
completed_at: Some("2018-01-01T01:01:01Z".to_string()),
status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::TimedOut),
conclusion: Some(Conclusion::Cancelled),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()),
head_sha: "abc123".to_string(),
output: Some(Output {
title: "Build Results".to_string(),
summary: "Attempted: foo
".to_string(),
Build timed out.".to_string(),
text: Some("## Partial log
```