Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libretro.dolphin: add missing dependencies to fix build #51301

Merged
merged 1 commit into from Dec 19, 2018

Conversation

timor
Copy link
Member

@timor timor commented Dec 1, 2018

Motivation for this change

Building retroarch with dolphin did not work, as the core complained about missing dependencies during config phase. This should fix the build. Note that I did not test the core itself, as I don't have any corresponding test images for that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 1, 2018

@GrahamcOfBorg build libretro.dolphin

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 1, 2018

It should be disabled on Darwin and ARM platforms because it can't build.

@matthewbauer matthewbauer merged commit df90fdf into NixOS:master Dec 19, 2018
@timor timor deleted the libretro-dolphin-dep-fix branch January 21, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants