Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 8560887e887e
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 947be9e99238
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 29, 2018

  1. iso-image: Verifies the FAT partition at build. 

    This is done to ensure `mtools`-based operations leave a clean FS.
    @samueldr
    samueldr committed Nov 29, 2018
    Copy the full SHA
    0a367c4 View commit details
    Browse the repository at this point in the history

  2. iso-image: Do not use batch operations for mcopy. 

    ```
       b      Batch mode. Optimized for huge recursive copies, but less secure if a crash happens during the copy.
```

It seems the "less secure if a crash happens" does not need a crash to
happen.

With batch mode:

```
/[...]/.
  Start (0) does not point to parent (___)
```

For pretty much everything copied in.

Without batch mode, everything passes `fsck`.

See #51150
    @samueldr
    samueldr committed Nov 29, 2018
    Copy the full SHA
    3864438 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2018

  1. Merge pull request #51199 from samueldr/fix/iso-image-fat32 

    iso-image: Verifies the FAT partition at build.
    @c0bw3b
    c0bw3b committed Dec 1, 2018
    Copy the full SHA
    947be9e View commit details
    Browse the repository at this point in the history