Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dwm-status: add module #51319

Merged
merged 1 commit into from
Aug 9, 2019
Merged

nixos/dwm-status: add module #51319

merged 1 commit into from
Aug 9, 2019
+81 −0

Conversation

Gerschtli
Copy link
Contributor

@Gerschtli Gerschtli commented Dec 1, 2018 •
edited
Loading

Motivation for this change

Add module to add dwm-status user systemd service and to setup the config file.

Modified module definition of @geistesk.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Gerschtli Gerschtli requested a review from infinisil as a code owner December 1, 2018 16:38
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 1, 2018
@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch from c2ab168 to 67f525c Compare December 1, 2018 16:44
@GrahamcOfBorg GrahamcOfBorg added 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 1, 2018
@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch 2 times, most recently from 1e8ce31 to 0567950 Compare December 3, 2018 18:12
@Gerschtli
Copy link
Contributor Author

Are there any reviewers?

@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch from 0567950 to e2a98c9 Compare December 27, 2018 19:26
@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch from e2a98c9 to 5d04b33 Compare January 5, 2019 10:09
@Gerschtli
Copy link
Contributor Author

Any reviewers?

oxzi
oxzi suggested changes Jan 15, 2019
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request and please excuse the late reply.

@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch 2 times, most recently from 2d4c11d to b6f9e7b Compare January 18, 2019 16:04
infinisil
infinisil requested changes Jan 23, 2019
View reviewed changes
@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch from b6f9e7b to 8b94f9b Compare January 24, 2019 14:41
@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch from 8b94f9b to 6031b0b Compare February 3, 2019 16:14
@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch from 6031b0b to 55975d8 Compare February 4, 2019 19:45
@Gerschtli
Copy link
Contributor Author

What is the state of this PR?

@Gerschtli Gerschtli force-pushed the add/programs-dwm-status branch from 55975d8 to 003b42f Compare June 11, 2019 22:15
@Gerschtli
Copy link
Contributor Author

Is there anyone how can merge this PR?

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Jun 11, 2019
@Gerschtli Gerschtli mentioned this pull request Jul 23, 2019
Merged
10 tasks
@worldofpeace worldofpeace requested a review from infinisil July 23, 2019 19:52
@infinisil infinisil merged commit 013d403 into NixOS:master Aug 9, 2019
@infinisil
Copy link
Member

Looking good, thanks :)

@Gerschtli Gerschtli deleted the add/programs-dwm-status branch August 9, 2019 14:20
@Gerschtli
Copy link
Contributor Author

@infinisil Maybe you want to have a look at #66445. I improved this module. Unfortunately the idea came to me after you have merged this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilpner tilpner

@oxzi oxzi

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gerschtli @infinisil @tilpner @oxzi @GrahamcOfBorg