Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liberation fonts: updates #51331

Closed
wants to merge 9 commits into from
Closed

liberation fonts: updates #51331

wants to merge 9 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 1, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@volth Any reason why we need binary and source packages?

@worldofpeace worldofpeace self-assigned this Dec 12, 2018
@worldofpeace
Copy link
Contributor

worldofpeace commented Dec 12, 2018 •
edited

@volth Any reason why we need binary and source packages?

Binary could be removed

@volth Did the thing 0e822cb

worldofpeace
worldofpeace reviewed Dec 12, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
liberation_ttf = liberation_ttf_v2_binary;
liberation_ttf_v1
liberation_ttf_v2
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of this semicolon is purposeful.

@worldofpeace
liberation fonts: drop binary packages
92a4bcf 
That means the following packages  are removed:
  - liberation_ttf_v1_binary
  - liberation_ttf_v2_binary

I've renamed these attributes because the binary form is removed:

  - liberation_ttf_v1_from_source -> liberation_ttf_v1
  - liberation_ttf_v2_from_source -> liberation_ttf_v2

Aliases are added for these.
@worldofpeace worldofpeace mentioned this pull request Dec 13, 2018
Merged
10 tasks
@dtzWill dtzWill mentioned this pull request Mar 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees

@worldofpeace worldofpeace

Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @worldofpeace @GrahamcOfBorg