New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCI32: Fix QFG4 peering at absent bats #1429
Conversation
89955bf
to
f6ddae5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to comment to a specific line, but the very last one:
{ true, 644, "fix peer bats, lower door", 1, qfg4LowerPeerBatsSignature, qfg4LowerPeerBatsPatch },
Shouldn't it come after room 633 in the next line?
I believe you do that by looking at the code, and a blue plus appears beside the line numbers. Click that.
Yep. Thanks for noticing. |
2d93fc1
to
7c589c5
Compare
Fixed the upper room. |
e12891b
to
4598537
Compare
Switched to UINT16 for a couple large pushi values (>127). They'd worked here, but I prefer to avoid that ambiguity.
|
6a75462
to
a24b51e
Compare
306eab4
to
a027a3c
Compare
dbdf4a7
to
4f02c54
Compare
296be11
to
513d37c
Compare
c0a3be1
to
8babbe9
Compare
d994694
to
f67d02e
Compare
ab99d97
to
851e4c4
Compare
Fixes castle doors when all bats have been killed, bug #10789
851e4c4
to
2f155c5
Compare
I finally found some time to review this. Well done, rewriting a now unused function to save bytes is quite clever :) Merging |
Fixes castle doors when all bats have been killed, bug #10789
One patch for the lower door.
Three for the upper door.
To test...