Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minio/minio-client: update #51300

Merged
merged 2 commits into from Dec 11, 2018
Merged

minio/minio-client: update #51300

merged 2 commits into from Dec 11, 2018

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Nov 30, 2018 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tilpner tilpner changed the title Minio update minio/minio-client: update Dec 1, 2018
@grahamc
Copy link
Member

grahamc commented Dec 1, 2018

@GrahamcOfBorg build minio minio-client

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/ofborg-now-uses-checks/1558/1

@tilpner
Copy link
Member Author

tilpner commented Dec 1, 2018 •
edited

(This comment previously said not to merge)

There is a bug with minio and MINIO_BROWSER=off, in which an infinite redirect to http(s)://host/minio/minio/minio/minio/... happens. minio/minio#6907

We could wait until it is resolved, try to patch it, or just merge anyway.

@tilpner
Copy link
Member Author

tilpner commented Dec 5, 2018

Previously mentioned bug was reported and is now fixed. Do we wait for the next release or package an intermediate revision?

@tilpner tilpner requested a review from FRidh as a code owner December 11, 2018 12:51
@tilpner tilpner closed this Dec 11, 2018
@tilpner tilpner reopened this Dec 11, 2018
@tilpner
Copy link
Member Author

tilpner commented Dec 11, 2018

@GrahamcOfBorg build minio minio-client

@tilpner
Copy link
Member Author

tilpner commented Dec 11, 2018

All the above noise was because of a git mistake I made. I didn't click any buttons to request a review, or close the PR. Sorry about that.

@srhb srhb merged commit 84bf8f3 into NixOS:master Dec 11, 2018
@flokli
Copy link
Contributor

flokli commented Jan 9, 2019

backported to 18.09 in ac184ee and b690ab1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tilpner @grahamc @nixos-discourse @flokli @srhb @GrahamcOfBorg