Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdirsyncer: fix build #51349

Merged
merged 1 commit into from Dec 2, 2018
Merged

vdirsyncer: fix build #51349

merged 1 commit into from Dec 2, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 1, 2018

Motivation for this change

Disabled vdirsyncer tests, because our version of hypothesis is a bit new pimutils/vdirsyncer#779

Closes #51241

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Dec 1, 2018

I think it would be better to patch the failure. Otherwise its likely we will forget to re-enable the tests in the future.

@marsam
Copy link
Contributor Author

marsam commented Dec 1, 2018

sounds reasonable, I've added it as patch

timokau
timokau requested changes Dec 1, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commit message needs updating

@marsam
vdirsyncer: fix build
c154ecf 
- Add support for build on darwin
@marsam
Copy link
Contributor Author

marsam commented Dec 2, 2018

@timokau thanks, I missed that. updated

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build vdirsyncer

@M-Gregoire
Copy link
Member

I just tested your branch, It's working perfectly 💯

Thanks for looking into it.

@worldofpeace
Copy link
Contributor

Tested as well and it builds fine 👍

@worldofpeace worldofpeace merged commit 3f4cbd4 into NixOS:master Dec 2, 2018
@marsam marsam deleted the feature/fix-vdirsyncer branch December 2, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @timokau @worldofpeace @M-Gregoire @GrahamcOfBorg