Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk220x: drop #51296

Merged
merged 1 commit into from Nov 30, 2018
Merged

webkitgtk220x: drop #51296

merged 1 commit into from Nov 30, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 30, 2018 •
edited

Motivation for this change

Follow-up to #45950 and #47949

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 30, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 and removed 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 30, 2018
@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 30, 2018
@jtojnar jtojnar merged commit 3a3513e into NixOS:staging Nov 30, 2018
@jtojnar jtojnar deleted the webkitgtk-cleanup branch December 1, 2018 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg