Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scilab-bin: adding bin/scilab symlink #51346

Merged
merged 1 commit into from Dec 1, 2018
Merged

Conversation

fusion809
Copy link
Contributor

@fusion809 fusion809 commented Dec 1, 2018

Should fix #51343; merely adding a scilab symlink within the bin/ directory, so that it can be detected by SageMath.

Motivation for this change

Desire to fix #51343, plus this sounds like it might save a little work for users that wish to launch the app from the command-line.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS) (I built on NixOS and as = true; is apparently the default this must have been used).
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Dec 1, 2018

Typo: This should fix #51343, not #51342.

@GrahamcOfBorg build scilab-bin

@fusion809 fusion809 changed the title scilab: adding bin/scilab symlink scilab-bin: adding bin/scilab symlink Dec 1, 2018
Should fix NixOS#51343, merely adding a scilab symlink within the bin/ directory, so that it can be detected by SageMath.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scilab-bin: Add 'scilab' executable to PATH, so as to make it integrate better into SageMath
3 participants