roon-server: init 100500363 #51308
Closed
roon-server: init 100500363 #51308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovek323
commented
Dec 1, 2018
lovek323
force-pushed
the
roon-server
branch
2 times, most recently
from
c30255b
to
516ba24
Compare
lovek323
commented
Dec 1, 2018
|
Is there something I should be doing to fix the errors with this build? |
lovek323
force-pushed
the
roon-server
branch
2 times, most recently
from
a126a09
to
c8e926a
Compare
lovek323
force-pushed
the
roon-server
branch
from
c8e926a
to
ed65077
Compare
|
I'd also be interested in seeing this merged, as I'd love to move my media server to NixOS :) |
infinisil
requested changes
Mar 21, 2019
| wantedBy = [ "multi-user.target" ]; | ||
|
|
||
| serviceConfig = { | ||
| Environment = "\"ROON_DATAROOT=${cfg.dataDir}\""; |
There was a problem hiding this comment.
Use systemd.services.roon-server.environment.ROON_DATAROOT = cfg.dataDir; instead
| @@ -338,6 +338,7 @@ | |||
| minetest = 311; | |||
| rss2email = 312; | |||
| cockroachdb = 313; | |||
| roon-server = 314; | |||
There was a problem hiding this comment.
No need to allocate a static uid,gid
| serviceConfig = { | ||
| Environment = "\"ROON_DATAROOT=${cfg.dataDir}\""; | ||
| ExecStart = "${pkgs.bash}/bin/bash ${pkgs.roon-server}/opt/start.sh"; | ||
| ExecStartPre = "${pkgs.coreutils}/bin/mkdir -p ${cfg.dataDir} && chown ${cfg.user}:${cfg.group} ${cfg.dataDir}"; |
| ExecStartPre = "${pkgs.coreutils}/bin/mkdir -p ${cfg.dataDir} && chown ${cfg.user}:${cfg.group} ${cfg.dataDir}"; | ||
| LimitNOFILE = 8192; | ||
| PermissionsStartOnly = true; | ||
| User = "${cfg.user}"; |
There was a problem hiding this comment.
Just User = cfg.user; works. And you should also set Group =
|
|
||
| serviceConfig = { | ||
| Environment = "\"ROON_DATAROOT=${cfg.dataDir}\""; | ||
| ExecStart = "${pkgs.bash}/bin/bash ${pkgs.roon-server}/opt/start.sh"; |
There was a problem hiding this comment.
Why not call the script directly?
| sha256 = "1pdlglhmsm0l4k6g4l97ckw596ckw8nnxii60j1xg994kdiikz3s"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ alsaLib alsaUtils cifs_utils ffmpeg libav mono ]; |
There was a problem hiding this comment.
Pretty sure you can just remove this line
10 tasks
|
Closing in favour of #63551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I use this to organise and listen to my music.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)I haven't played with modules much, so I'd appreciate any suggestions/feedback on how this could improve. There is one thing I need specific help with - I'll add a comment inline.