Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teyjus: fix build by using omake from ocaml 4.02 package set #51345

Merged
merged 2 commits into from Dec 7, 2018
Merged

teyjus: fix build by using omake from ocaml 4.02 package set #51345

merged 2 commits into from Dec 7, 2018

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Dec 1, 2018

Motivation for this change

Package wouldn't evaluate since omake 0.9.x isn't available for Ocaml 4.06.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2018

@GrahamcOfBorg build teyjus

@vbgl
Copy link
Contributor

vbgl commented Dec 2, 2018

I guess omake_rc1 should be removed from all-packages.nix, since it is broken.

@bcdarwin
Copy link
Member Author

bcdarwin commented Dec 2, 2018 •
edited

In principle it could have also been changed to build against Ocaml 4.02, but since this is an Ocaml build system I don't think there's a strong reason to keep an older version around in all-packages.nix (it has no reverse dependencies), so I've removed it.

@vbgl vbgl merged commit cf9743d into NixOS:master Dec 7, 2018
@bcdarwin bcdarwin deleted the fix-teyjus-deps branch December 7, 2018 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcdarwin @Mic92 @vbgl @GrahamcOfBorg