Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llpp: 2018-03-02 -> 30 #51313

Merged
merged 1 commit into from Dec 19, 2018
Merged

llpp: 2018-03-02 -> 30 #51313

merged 1 commit into from Dec 19, 2018

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Dec 1, 2018

Remove unnecessary packages from derivation as well as fix sed commands
to rewrite build.bash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Enzime Enzime force-pushed the update/llpp branch 3 times, most recently from cf81746 to 5e0f5cc Compare December 10, 2018 04:51
@alyssais
Copy link
Member

41/151 Test #45: djpeg-shared-rgb-islow-icc-cmp ....................***Failed 0.12 sec
Could not obtain MD5 sum: No such file or directory

You should either fix this (maybe it just needs md5sum or something), disable the tests (or that specific test) on aarch64, or mark as broken on aarch64.

@Enzime
Copy link
Member Author

Enzime commented Dec 18, 2018

@alyssais Fixed 👍

Remove unnecessary packages from derivation and use patches to fix
build.bash instead of sed commands.
@matthewbauer matthewbauer merged commit 8f9bd40 into NixOS:master Dec 19, 2018
@Enzime Enzime deleted the update/llpp branch January 6, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants