Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanagerapplet: fix missing icons #51323

Closed
wants to merge 1 commit into from
Closed

networkmanagerapplet: fix missing icons #51323

wants to merge 1 commit into from
+2 −2

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Fix missing icons through adding hicolor-icon-theme in buildInputs.

Fixes #32730.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rycee rycee added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 2, 2018
@rycee
Copy link
Member

rycee commented Dec 2, 2018

Thanks! I'd also like to see this merged to 18.09.

@Gerschtli
Copy link
Contributor Author

Closed as resolved via #51379

@Gerschtli Gerschtli closed this Dec 2, 2018
@Gerschtli Gerschtli deleted the fix/networkmanagerapplet branch December 2, 2018 12:00
@jozuas jozuas mentioned this pull request Aug 31, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @rycee @GrahamcOfBorg