Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.docutils: set LANG in case of darwin and python3 #51311

Merged
merged 1 commit into from Dec 2, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 1, 2018

This should allow the Python3 version to be built while preventing mass-rebuilds.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This should allow the Python3 version to be built while preventing mass-rebuilds.
@FRidh
Copy link
Member Author

FRidh commented Dec 1, 2018

cc @marsam @worldofpeace @LnL7

@worldofpeace
Copy link
Contributor

Sounds right and should get things moving again.
in the future I'll remember to constrain things specifically when it comes down to this kind of detail.

@marsam
Copy link
Contributor

marsam commented Dec 2, 2018

when staging gets merged into master, will this change have precedence over db900da?

Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and should unblock unstable.

@LnL7 LnL7 merged commit 0e6e8c1 into NixOS:master Dec 2, 2018
@FRidh FRidh deleted the docutils branch December 30, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants