Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdata: fix python plugins #50509

Merged
merged 1 commit into from Nov 17, 2018
Merged

netdata: fix python plugins #50509

merged 1 commit into from Nov 17, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 17, 2018 •
edited

Motivation for this change

fixes #33366
cc @marsam

Tested here: https://netdata.thalheim.io/#menu_postgres_local_submenu_db_postgres;theme=slate;help=true

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 17, 2018
@Mic92
Copy link
Member Author

Mic92 commented Nov 17, 2018

@GrahamcOfBorg test netdata

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.netdata

Partial log (click to expand)

error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:27:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/lists.nix:113:41, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:46:
while evaluating the attribute 'netdata' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:140:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:140:13:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/i0lg67d40dl5qli803hgp3259n1ghk5l-rbvermaa-spot' is forbidden in restricted mode

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.netdata

Partial log (click to expand)

Cannot nix-instantiate `tests.netdata' because:
error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:347:27:
while evaluating the attribute 'netdata' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/tests/all-tests.nix:140:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/tests/all-tests.nix:140:13:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/f8703kn90nmx8bg8szs6ridk86csn22n-grahamc-aarch64-community-2' is forbidden in restricted mode

@Mic92
Copy link
Member Author

Mic92 commented Nov 17, 2018

So sad that ofborg's testing support is broken.

@Mic92 Mic92 mentioned this pull request Nov 17, 2018
Closed
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: netdata

Partial log (click to expand)

/nix/store/lrl54ygmarisd9p6jdx2f273m59ggp8q-netdata-1.11.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: netdata

Partial log (click to expand)

/nix/store/nfffla7iwygv0sqbpm3r1y2pibbxfcqj-netdata-1.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: netdata

Partial log (click to expand)

/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/alarm-test.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/cgroup-name.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/cgroup-network-helper.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/charts.d.dryrun-helper.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/charts.d.plugin: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/fping.plugin: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/node.d.plugin: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/python.d.plugin: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/libexec/netdata/plugins.d/tc-qos-helper.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
moving /nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/sbin/* to /nix/store/dr2vyh26w7j8wapwirkpj3lcgp0gc55y-netdata-1.11.0/bin

@Mic92 Mic92 merged commit 9ba5ad5 into NixOS:master Nov 17, 2018
@Mic92 Mic92 deleted the netdata branch November 17, 2018 20:34
@Mic92
Copy link
Member Author

Mic92 commented Nov 17, 2018

backport:

[detached HEAD f0445db] netdata: fix python plugins
Date: Sat Nov 17 15:11:46 2018 +0000
1 file changed, 28 insertions(+), 1 deletion(-)

@Mic92 Mic92 restored the netdata branch November 21, 2018 23:00
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netdata: All python plugins broken
4 participants
@Mic92 @GrahamcOfBorg @marsam @samueldr