Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-desktop: fix path substitution #50507

Merged
merged 1 commit into from Nov 17, 2018
Merged

gnome3.gnome-desktop: fix path substitution #50507

merged 1 commit into from Nov 17, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Nov 17, 2018

Motivation for this change

fixes #50494

I'll add the same fix to the gnome 3.30 PR.

Things done

Checked that thumbnail generation works in nautilus.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@hedning
gnome3.gnome-desktop: fix path substitution
35c64e5 
`substituteAll` intentionally doesn't work with all caps:
NixOS#28086
@hedning hedning requested a review from jtojnar November 17, 2018 15:31
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 17, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Nov 17, 2018

I wonder why substituteAll stopped substituting variables starting with uppercase letter.

@hedning
Copy link
Contributor Author

hedning commented Nov 17, 2018 •
edited

Yeah, it's a bit weird, I did notice that thumbnails stopped working a while back, but I'm pretty sure it must have worked at some point after you made this patch. Though apparently it is supposed to have been like this for long time #9482

@jtojnar jtojnar merged commit 656288f into NixOS:release-18.09 Nov 17, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Nov 17, 2018

Maybe #28799

@hedning hedning deleted the fix-nautilus-thumbnails branch November 18, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @jtojnar @GrahamcOfBorg