Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero-gui: 0.13.0.3 -> 0.13.0.4 #50485

Merged
merged 1 commit into from Nov 17, 2018
Merged

monero-gui: 0.13.0.3 -> 0.13.0.4 #50485

merged 1 commit into from Nov 17, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Nov 17, 2018

Motivation for this change

Update gui following the monero(-cli) update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested connection to a node and syncronization of blocks.
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I disabled the support for non-x86_64-linux platforms as I don't know how to test/fix the build.

@Mic92
Copy link
Member

Mic92 commented Nov 17, 2018

@GrahamcOfBorg build monero-gui

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: monero-gui

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: monero-gui

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: monero-gui

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: monero-gui

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: monero-gui

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4
shrinking /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4/bin/monero-wallet-gui
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4/bin
patching script interpreter paths in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4
checking for references to /build in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: monero-gui

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4
shrinking /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4/bin/monero-wallet-gui
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4/bin
patching script interpreter paths in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4
checking for references to /build in /nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/6zbdx6vwy35fwvgbd7g24gpk08yl742c-monero-gui-0.13.0.4

@Mic92 Mic92 merged commit 5f7208a into NixOS:master Nov 17, 2018
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 17, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @Mic92 @GrahamcOfBorg