chromiumOzone: init new chromium derivative package for Wayland #50486

colemickens · 2018-11-17T02:01:54Z

Motivation for this change

firefox-nightly-bin packages from nixpkgs-mozilla now have Wayland support enabled by default.
Chromium has some Wayland support via Ozone, but it's not the default build config.
The Chromium build infra is not simple, and I also don't have time to create a chromium-git to place in an overlay, which might be preferable to adding more variants of Chromium to nixpkgs.
This is working, in that as much work as is expected for an Ozone/Wayland build.
I'm pushing builds of chromiumOzone to nixpkgs-wayland's cachix repo. More info: https://github.com/colemickens/nixpkgs-wayland. (Though I'm building this against nixos-unstable, whereas this PR targets master.)

Signed-off-by: Cole Mickens cole.mickens@gmail.com

LINKS ABOUT CHROMIUM/OZONE

comment indicating that Ozone Wayland builds should be somewhat functional: https://bugs.chromium.org/p/chromium/issues/detail?id=578890&desc=2#c102
docs on building for Linux desktop w/ Ozone-Wayland: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ozone_overview.md#linux-desktop-waterfall
open issue indicating that upstream Chromium might need to be patched for Ozone on Linux scenarios: chromium-ozone-wayland fails when gbm is not availiable OSSystems/meta-browser#187

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

colemickens · 2018-11-17T02:02:26Z

Shamelessly tagging @volth since you have been working with Chromium a lot lately and might have good insight. Thanks in advance.

colemickens · 2018-11-17T02:03:25Z

pkgs/applications/networking/browsers/chromium/common.nix


 # package customization
 , enableNaCl ? false
 , enableWideVine ? false
+, useOzoneWayland ? false


possibly should just be "useOzone" since there is an x11 backend for Ozone and I currently have it enabled.

That would be less confusing.

Mic92 · 2018-11-17T10:29:08Z

pkgs/applications/networking/browsers/chromium/common.nix

@@ -252,6 +255,13 @@ let
      proprietary_codecs = true;
      enable_hangout_services_extension = true;
      ffmpeg_branding = "Chrome";
+    } // optionalAttrs useOzoneWayland {


Is chromium going to be mutual exclusive with x11 support?

No, Ozone does not mean any sort of mutual exclusivity, and the GN flags here explicitly enable both the x11 and wayland backends for Ozone. The toggle here is really useOzone: ie, useOzone=false means the existing shipping Chromium display tech (GTK and X11), and useOzone=true means to switch to the new Chromium display stack (Ozone) and enable both the X11 and Wayland backends for it.

colemickens · 2018-11-30T03:19:54Z

So, I've got it building, and getting past the initial minigbm problems. However, I can't get it working due to issues with libGLESv2.so.2.

I've tried having libGL in buildInputs, as well as, libglvnd, but they both result in the same error. I'm not sure if some additional source patches are needed to work properly with nixpkgs's usage of GL?

[6662:6662:1129/191754.584226:ERROR:egl_util.cc(59)] Failed to load GLES library: libGLESv2.so.2: cannot open shared object file: No such file or directory

colemickens · 2018-11-30T03:24:46Z

Actually, it should have already had libGL anyway, since it has libGLU_combined by default.

colemickens · 2018-11-30T11:21:22Z

pkgs/applications/networking/browsers/chromium/common.nix

@@ -113,7 +117,7 @@ let
      ninja which python2Packages.python perl pkgconfig
      python2Packages.ply python2Packages.jinja2 nodejs
      gnutar
-    ];
+    ] ++ optional (versionAtLeast version "72") jdk;


this can probably be dropped since jdk.jre is in buildInputs now...

colemickens · 2018-11-30T11:22:50Z

For anyone watching, this is now producing working builds of Chromium. (It doesn't handle high DPI well right now, just as a heads up).

Thanks to @Mic92 for getting me pointed in the right direction with regards to GL handling.

I need to test the regular Chromium builds to make sure I didn't regress anything, otherwise this can be reviewed...

colemickens · 2019-03-04T18:04:34Z

NOTE FOR POTENTIAL REVIEWERS: Lots of this is still in flux in Chromium repos and it may be prudent to hold off a bit. For example, building and using libminigbm should stop being required in Dev channels soon, in favor of using system mesa instead

bendlas · 2019-03-05T10:55:25Z

I like the work on vaapi, this should be useful, even independently of Ozone.

Could you put that into a separate PR?
Have you looked into vdpau support as well, by chance?

colemickens · 2019-03-05T16:02:20Z

@bendlas

There's another PR with a probably more correct approach to enabling vaapi: chromium: Add optional vaapi hw video decoding support #56794. I didn't actually mean to push the non-Ozone stuff to this branch, I'll try to get this a bit more organized soon. I haven't managed to get Ozone + Vaapi working yet (actually haven't gotten vaapi tested as working by itself yet either).
I don't really understand vaapi/vdpau well enough to understand if I need both. Would this be for NVIDIA users that don't have a vaapi impl? I was under the impression there was some sort of vaapi-vdpau compatibility layer that they could use? If you can give me some more hints here I can dig in.

bendlas · 2019-03-06T00:22:07Z

I found this really helpful https://wiki.archlinux.org/index.php/Hardware_video_acceleration

EDIT also potentially this
https://www.linuxuprising.com/2019/01/fedora-updates-chromium-with-vaapi.html

colemickens commented Nov 17, 2018

View reviewed changes

Mic92 reviewed Nov 17, 2018

View reviewed changes

colemickens force-pushed the nixpkgs-chromium-wayland branch 2 times, most recently from 09b32e8 to cedb136 Compare November 17, 2018 11:15

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Nov 17, 2018

colemickens force-pushed the nixpkgs-chromium-wayland branch 2 times, most recently from 65298af to 9f7014c Compare November 23, 2018 05:20

GrahamcOfBorg added the 2.status: merge conflict label Nov 23, 2018

colemickens force-pushed the nixpkgs-chromium-wayland branch 2 times, most recently from 785c03a to b334593 Compare November 29, 2018 14:05

GrahamcOfBorg removed the 2.status: merge conflict label Nov 29, 2018

colemickens force-pushed the nixpkgs-chromium-wayland branch from b334593 to e30a4d2 Compare November 29, 2018 14:26

colemickens force-pushed the nixpkgs-chromium-wayland branch 2 times, most recently from 5349f7d to b59d7fe Compare November 30, 2018 11:04

colemickens commented Nov 30, 2018

View reviewed changes

colemickens changed the title ~~[need help] chromiumWayland: add new chromium derivative package~~ chromiumOzone: init new chromium derivative package for Wayland Nov 30, 2018

jtojnar added this to Non-mainstream DE in Wayland Dec 26, 2018

jtojnar moved this from Non-mainstream DE to General in Wayland Dec 26, 2018

colemickens force-pushed the nixpkgs-chromium-wayland branch 2 times, most recently from ee41cbb to b3e1ccb Compare February 18, 2019 08:51

GrahamcOfBorg requested review from bendlas, chaoflow and garbas February 18, 2019 08:59

colemickens force-pushed the nixpkgs-chromium-wayland branch 3 times, most recently from 11bcdbe to b9fd4f3 Compare March 6, 2019 04:55

colemickens added 2 commits March 6, 2019 18:03

chromiumOzone: init new chromium variant w/ ozone

60c8321

chromium: update upstream-info

fd5efcf

colemickens force-pushed the nixpkgs-chromium-wayland branch from 43e48fb to fd5efcf Compare March 6, 2019 18:03

colemickens closed this Mar 17, 2019

colemickens deleted the nixpkgs-chromium-wayland branch March 17, 2019 00:16

ghost mentioned this pull request Jun 12, 2019

chromium: add useOzone and 'chromiumOzone' variant #61008

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chromiumOzone: init new chromium derivative package for Wayland #50486

chromiumOzone: init new chromium derivative package for Wayland #50486

colemickens commented Nov 17, 2018 •

edited

colemickens commented Nov 17, 2018

colemickens Nov 17, 2018

Mic92 Nov 17, 2018

Mic92 Nov 17, 2018

colemickens Nov 17, 2018

colemickens commented Nov 30, 2018

colemickens commented Nov 30, 2018

colemickens Nov 30, 2018

colemickens commented Nov 30, 2018

colemickens commented Mar 4, 2019

bendlas commented Mar 5, 2019

colemickens commented Mar 5, 2019

bendlas commented Mar 6, 2019 •

edited

chromiumOzone: init new chromium derivative package for Wayland #50486

chromiumOzone: init new chromium derivative package for Wayland #50486

Conversation

colemickens commented Nov 17, 2018 • edited

Motivation for this change

LINKS ABOUT CHROMIUM/OZONE

Things done

colemickens commented Nov 17, 2018

colemickens Nov 17, 2018

Choose a reason for hiding this comment

Mic92 Nov 17, 2018

Choose a reason for hiding this comment

Mic92 Nov 17, 2018

Choose a reason for hiding this comment

colemickens Nov 17, 2018

Choose a reason for hiding this comment

colemickens commented Nov 30, 2018

colemickens commented Nov 30, 2018

colemickens Nov 30, 2018

Choose a reason for hiding this comment

colemickens commented Nov 30, 2018

colemickens commented Mar 4, 2019

bendlas commented Mar 5, 2019

colemickens commented Mar 5, 2019

bendlas commented Mar 6, 2019 • edited

colemickens commented Nov 17, 2018 •

edited

bendlas commented Mar 6, 2019 •

edited