Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pakcs: 2.0.2-b9 -> 2.0.2 #50487

Merged
merged 1 commit into from Nov 17, 2018
Merged

pakcs: 2.0.2-b9 -> 2.0.2 #50487

merged 1 commit into from Nov 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 17, 2018

@GrahamcOfBorg build pakcs

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: pakcs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pakcs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Mic92
Mic92 reviewed Nov 17, 2018
View reviewed changes
pkgs/development/compilers/pakcs/default.nix
@@ -6,9 +6,11 @@
let
name = "pakcs-2.0.2";

# Don't switch to development release without a reason, because its
# source updates without version bump. Prefer current release instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it was also 2.0.2 before so what did change here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 there were series of betas (as seen in commit log) - 2.0.2-b7, then 2.0.2-b9. And I was forced to use betas, because 2.0.1 has fundamental issue (records support is broken) and everything lower doesn't build anymore.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 sorry for not updating name approprietary before.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pakcs

Partial log (click to expand)

/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/scripts/cleancurry.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/scripts/configure-pakcs: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/scripts/pakcs.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/scripts/pakcs-makesavedstate.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/testsuite/test.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/tools/Peval/peval: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/frontend/curry-frontend/debian/rules: interpreter directive changed from "/usr/bin/make -f" to "/nix/store/fabhw7nzi5ij0ff3dljxnfnldgzrcqgv-gnumake-4.2.1/bin/make -f"
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2/pakcs/frontend/curry-base/debian/rules: interpreter directive changed from "/usr/bin/make -f" to "/nix/store/fabhw7nzi5ij0ff3dljxnfnldgzrcqgv-gnumake-4.2.1/bin/make -f"
checking for references to /build in /nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2...
/nix/store/s883c0rbkkqkljk0rzwksrgj1981g3zq-pakcs-2.0.2

@Mic92 Mic92 merged commit 55992b0 into NixOS:master Nov 17, 2018
@ghost
Copy link
Author

ghost commented Nov 17, 2018

@Mic92 Thanks!

@ghost ghost deleted the pakcs branch November 17, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg