Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d1eb06cb185c
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 07eaaf6c8b8c
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 6, 2018

  1. nixos/mysql: Explicitly set datadir in my.cnf 

    While this seems silly at first (it's already given as start parameter
to mysqld), it seems like xtrabackup needs that sometimes.
Without it, a Galera cluster cannot be run using the xtrabackup
replication method.
    @dasJ
    dasJ committed Nov 6, 2018
    Copy the full SHA
    c7f5457 View commit details

Commits on Nov 16, 2018

  1. Merge pull request #49838 from dasJ/mysql-datadir 

    nixos/mysql: Explicitly set datadir in my.cnf
    @samueldr
    samueldr authored Nov 16, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    07eaaf6 View commit details
Showing with 1 addition and 0 deletions.
  1. +1 −0 nixos/modules/services/databases/mysql.nix
1 change: 1 addition & 0 deletions nixos/modules/services/databases/mysql.nix
View file
Original file line number Diff line number Diff line change
@@ -23,6 +23,7 @@ let
''
[mysqld]
port = ${toString cfg.port}
datadir = ${cfg.dataDir}
${optionalString (cfg.bind != null) "bind-address = ${cfg.bind}" }
${optionalString (cfg.replication.role == "master" || cfg.replication.role == "slave") "log-bin=mysql-bin"}
${optionalString (cfg.replication.role == "master" || cfg.replication.role == "slave") "server-id = ${toString cfg.replication.serverId}"}