Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openconnect pa #50513

Merged
merged 13 commits into from Nov 17, 2018
Merged

Add openconnect pa #50513

merged 13 commits into from Nov 17, 2018

Conversation

chessai
Copy link
Member

@chessai chessai commented Nov 17, 2018 •
edited

Motivation for this change

openconnect does not support Palo Alto Network's GlobalProtect protocol. I use a fork of openconnect regularly at work, where all of our traffic goes through a PA firewall. The package is actively maintained by @dlenski and is in use by many active developers. The fork is located at https://github.com/dlenski/openconnect

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
    • Ubuntu 16.04
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@chessai
Copy link
Member Author

chessai commented Nov 17, 2018 •
edited

I believe that the unchecked boxes don't apply, other than macOS and other Linux distributions. I don't have access to any other machines than NixOS 19.03 and Ubuntu 16.04, and it built/worked on those

worldofpeace
worldofpeace suggested changes Nov 17, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more popular commit msg for the maintainers list would be

maintainers: add chessai

worldofpeace and others added 2 commits November 17, 2018 15:03
@worldofpeace @chessai
Apply suggestions from code review
86dc05c 
Co-Authored-By: chessai <chessai@users.noreply.github.com>
@chessai
use rec instead of let ... in
5b0f33a
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build openconnect_pa

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openconnect_pa

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/4cqgljvjsi2msd832kkg9l9q04d1p3g9-openconnect_pa-unstable-2018-10-08/lib  /nix/store/4cqgljvjsi2msd832kkg9l9q04d1p3g9-openconnect_pa-unstable-2018-10-08/sbin
patching script interpreter paths in /nix/store/4cqgljvjsi2msd832kkg9l9q04d1p3g9-openconnect_pa-unstable-2018-10-08
checking for references to /build in /nix/store/4cqgljvjsi2msd832kkg9l9q04d1p3g9-openconnect_pa-unstable-2018-10-08...
moving /nix/store/4cqgljvjsi2msd832kkg9l9q04d1p3g9-openconnect_pa-unstable-2018-10-08/sbin/* to /nix/store/4cqgljvjsi2msd832kkg9l9q04d1p3g9-openconnect_pa-unstable-2018-10-08/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/wf6n1nfqh5n5jsk70afr1dcp9z4ksrp3-openconnect_pa-unstable-2018-10-08-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wf6n1nfqh5n5jsk70afr1dcp9z4ksrp3-openconnect_pa-unstable-2018-10-08-dev/lib
patching script interpreter paths in /nix/store/wf6n1nfqh5n5jsk70afr1dcp9z4ksrp3-openconnect_pa-unstable-2018-10-08-dev
checking for references to /build in /nix/store/wf6n1nfqh5n5jsk70afr1dcp9z4ksrp3-openconnect_pa-unstable-2018-10-08-dev...
/nix/store/4cqgljvjsi2msd832kkg9l9q04d1p3g9-openconnect_pa-unstable-2018-10-08

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openconnect_pa

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/jmwsh63793kp56y7h4kwkj8pl67ws25m-openconnect_pa-unstable-2018-10-08/lib  /nix/store/jmwsh63793kp56y7h4kwkj8pl67ws25m-openconnect_pa-unstable-2018-10-08/sbin
patching script interpreter paths in /nix/store/jmwsh63793kp56y7h4kwkj8pl67ws25m-openconnect_pa-unstable-2018-10-08
checking for references to /build in /nix/store/jmwsh63793kp56y7h4kwkj8pl67ws25m-openconnect_pa-unstable-2018-10-08...
moving /nix/store/jmwsh63793kp56y7h4kwkj8pl67ws25m-openconnect_pa-unstable-2018-10-08/sbin/* to /nix/store/jmwsh63793kp56y7h4kwkj8pl67ws25m-openconnect_pa-unstable-2018-10-08/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/4y6did8px6h0k0caziqq4rs9796q1yg4-openconnect_pa-unstable-2018-10-08-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4y6did8px6h0k0caziqq4rs9796q1yg4-openconnect_pa-unstable-2018-10-08-dev/lib
patching script interpreter paths in /nix/store/4y6did8px6h0k0caziqq4rs9796q1yg4-openconnect_pa-unstable-2018-10-08-dev
checking for references to /build in /nix/store/4y6did8px6h0k0caziqq4rs9796q1yg4-openconnect_pa-unstable-2018-10-08-dev...
/nix/store/jmwsh63793kp56y7h4kwkj8pl67ws25m-openconnect_pa-unstable-2018-10-08

worldofpeace
worldofpeace approved these changes Nov 17, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds and I can verify the binary executes, though I can't test the function.

cc @c0bw3b @Mic92 (mergers)

Don't forget to squash/fixup your commits

Where:

maintainers: add chessai
openconnect_pa: init at unstable-2018-10-08

Are the acceptable messages.

@chessai
Copy link
Member Author

chessai commented Nov 17, 2018

thanks for taking the time to review this, @worldofpeace.

as far as it working, i was able to use it to authenticate, attempt to connect to my work's network remotely, get prompted by google duo, and then ssh into a machine there which i would otherwise not have access to

@worldofpeace
Copy link
Contributor

thanks for taking the time to review this, @worldofpeace.

as far as it working, i was able to use it to authenticate, attempt to connect to my work's network remotely, get prompted by google duo, and then ssh into a machine there which i would otherwise not have access to

Thanks for contributing ❇️

Good to see that you can verify its function.

@Mic92 Mic92 merged commit 1156427 into NixOS:master Nov 17, 2018
@worldofpeace
Copy link
Contributor

@Mic92 erm, those commits were supposed to be squashed 😆

@Mic92
Copy link
Member

Mic92 commented Nov 17, 2018

Yeah, sorry. I hit the wrong button.

@chessai chessai mentioned this pull request Nov 18, 2018
Closed
@kini kini mentioned this pull request Dec 16, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chessai @worldofpeace @GrahamcOfBorg @Mic92