exiv2: 0.26.x -> 0.27.x #50496

periklis · 2018-11-17T13:48:33Z

Motivation for this change

fix for #50369

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions (nix-docker)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

fixes NixOS#50369

Mic92 · 2018-11-17T13:57:10Z

@GrahamcOfBorg build exiv2

GrahamcOfBorg · 2018-11-17T13:58:02Z

Success on aarch64-linux (full log)

Attempted: exiv2

Partial log (click to expand)

gzipping man pages under /nix/store/ypqcwl9zdnkvn9ipdxqsh1awjy838sr8-exiv2-0.27-rc1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ypqcwl9zdnkvn9ipdxqsh1awjy838sr8-exiv2-0.27-rc1/lib  /nix/store/ypqcwl9zdnkvn9ipdxqsh1awjy838sr8-exiv2-0.27-rc1/bin
patching script interpreter paths in /nix/store/ypqcwl9zdnkvn9ipdxqsh1awjy838sr8-exiv2-0.27-rc1
checking for references to /build in /nix/store/ypqcwl9zdnkvn9ipdxqsh1awjy838sr8-exiv2-0.27-rc1...
shrinking RPATHs of ELF executables and libraries in /nix/store/4x4nq2z6n0ghzgp21fmp2a56vqp4l00v-exiv2-0.27-rc1-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/4x4nq2z6n0ghzgp21fmp2a56vqp4l00v-exiv2-0.27-rc1-dev
checking for references to /build in /nix/store/4x4nq2z6n0ghzgp21fmp2a56vqp4l00v-exiv2-0.27-rc1-dev...
/nix/store/ypqcwl9zdnkvn9ipdxqsh1awjy838sr8-exiv2-0.27-rc1

GrahamcOfBorg · 2018-11-17T13:58:58Z

Success on x86_64-linux (full log)

Attempted: exiv2

Partial log (click to expand)

shrinking /nix/store/w6y690i4rf5cvaabpg8jppbydgv21kml-exiv2-0.27-rc1/bin/path-test
gzipping man pages under /nix/store/w6y690i4rf5cvaabpg8jppbydgv21kml-exiv2-0.27-rc1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w6y690i4rf5cvaabpg8jppbydgv21kml-exiv2-0.27-rc1/lib  /nix/store/w6y690i4rf5cvaabpg8jppbydgv21kml-exiv2-0.27-rc1/bin
patching script interpreter paths in /nix/store/w6y690i4rf5cvaabpg8jppbydgv21kml-exiv2-0.27-rc1
checking for references to /build in /nix/store/w6y690i4rf5cvaabpg8jppbydgv21kml-exiv2-0.27-rc1...
shrinking RPATHs of ELF executables and libraries in /nix/store/c5mvmjvzcnzydl5bmg0p62rl08hx1n9l-exiv2-0.27-rc1-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/c5mvmjvzcnzydl5bmg0p62rl08hx1n9l-exiv2-0.27-rc1-dev
checking for references to /build in /nix/store/c5mvmjvzcnzydl5bmg0p62rl08hx1n9l-exiv2-0.27-rc1-dev...

GrahamcOfBorg · 2018-11-17T13:59:43Z

Success on x86_64-darwin (full log)

Attempted: exiv2

Partial log (click to expand)

-- Installing: /nix/store/mii0sm2lz898n95ml4ayppmxsv8xkrxq-exiv2-0.27-rc1/bin/geotag
-- Installing: /nix/store/mii0sm2lz898n95ml4ayppmxsv8xkrxq-exiv2-0.27-rc1/share/man/man1/exiv2samples.1
post-installation fixup
gzipping man pages under /nix/store/mii0sm2lz898n95ml4ayppmxsv8xkrxq-exiv2-0.27-rc1/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mii0sm2lz898n95ml4ayppmxsv8xkrxq-exiv2-0.27-rc1/lib  /nix/store/mii0sm2lz898n95ml4ayppmxsv8xkrxq-exiv2-0.27-rc1/bin
patching script interpreter paths in /nix/store/mii0sm2lz898n95ml4ayppmxsv8xkrxq-exiv2-0.27-rc1
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/w3qdzpipmm28s31raa3hcvqgxp1b5y00-exiv2-0.27-rc1-dev
/nix/store/mii0sm2lz898n95ml4ayppmxsv8xkrxq-exiv2-0.27-rc1

Mic92 · 2018-11-17T14:16:58Z

@GrahamcOfBorg build python36Packages.py3exiv2 gegl_0_4

GrahamcOfBorg · 2018-11-17T14:17:25Z

Failure on x86_64-darwin (full log)

Attempted: python36Packages.py3exiv2, gegl_0_4

Partial log (click to expand)

        BasicError(ErrorCode code, const A& arg1, const B& arg2);
        ^
/nix/store/w3qdzpipmm28s31raa3hcvqgxp1b5y00-exiv2-0.27-rc1-dev/include/exiv2/error.hpp:280:9: note: candidate constructor template not viable: requires 4 arguments, but 1 was provided
        BasicError(ErrorCode code, const A& arg1, const B& arg2, const C& arg3);
        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
error: command 'clang++' failed with exit status 1
builder for '/nix/store/ywni4d4yyzh9gib97jq1pp4nl11am7kn-python3.6-py3exiv2-0.4.0.drv' failed with exit code 1
error: build of '/nix/store/n36pagrmbf98m6m3753q2wn2hrr6slpk-gegl-0.4.12.drv', '/nix/store/ywni4d4yyzh9gib97jq1pp4nl11am7kn-python3.6-py3exiv2-0.4.0.drv' failed

GrahamcOfBorg · 2018-11-17T14:17:34Z

Failure on x86_64-linux (full log)

Attempted: python36Packages.py3exiv2, gegl_0_4

Partial log (click to expand)

Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /nix/store/sbg7j9ghnhl3kiw5gck9khhr2wwd5y8f-pkg-config-0.29.2/bin/pkg-config (0.29.2)

meson.build:5:0: ERROR:  Native dependency 'exiv2' not found

A full log can be found at /build/gexiv2-0.10.8/build/meson-logs/meson-log.txt
builder for '/nix/store/rilp4wgyvqj4pmaglbqgc03a5ij08hbj-gexiv2-0.10.8.drv' failed with exit code 1
cannot build derivation '/nix/store/jn91g4amayjic46m4bgqg8299i84h4ac-gegl-0.4.12.drv': 1 dependencies couldn't be built
error: build of '/nix/store/47130d260x050xcy7fm67c1d1qsrkrk7-python3.6-py3exiv2-0.4.0.drv', '/nix/store/jn91g4amayjic46m4bgqg8299i84h4ac-gegl-0.4.12.drv' failed

GrahamcOfBorg · 2018-11-17T14:17:44Z

Failure on aarch64-linux (full log)

Attempted: python36Packages.py3exiv2, gegl_0_4

Partial log (click to expand)

     BasicError<charT>::BasicError(ErrorCode code)
     ^~~~~~~~~~~~~~~~~
/nix/store/4x4nq2z6n0ghzgp21fmp2a56vqp4l00v-exiv2-0.27-rc1-dev/include/exiv2/error.hpp:336:5: note:   candidate expects 1 argument, 2 provided
/nix/store/4x4nq2z6n0ghzgp21fmp2a56vqp4l00v-exiv2-0.27-rc1-dev/include/exiv2/error.hpp:263:11: note: candidate: Exiv2::BasicError<char>::BasicError(const Exiv2::BasicError<char>&)
     class BasicError : public AnyError {
           ^~~~~~~~~~
/nix/store/4x4nq2z6n0ghzgp21fmp2a56vqp4l00v-exiv2-0.27-rc1-dev/include/exiv2/error.hpp:263:11: note:   candidate expects 1 argument, 2 provided
error: command 'gcc' failed with exit status 1
builder for '/nix/store/pi4kcr556zkcqj0ldc39qh2md7aikbyq-python3.6-py3exiv2-0.4.0.drv' failed with exit code 1
error: build of '/nix/store/h316cib1jg9nmccvfkfw81sjsqxpmcvc-gegl-0.4.12.drv', '/nix/store/pi4kcr556zkcqj0ldc39qh2md7aikbyq-python3.6-py3exiv2-0.4.0.drv' failed

vcunat · 2018-11-23T15:07:04Z

They've released RC2 already. There are some new Coverity fixes in the log, so that's possibly also relevant for security.

vcunat · 2018-11-23T15:13:45Z

The new build system also installs very many new executables. Maybe there were some other caveats; I've forgotten since the last time I've tried pre-0.27.

ckauhaus · 2018-11-26T08:59:14Z

@periklis I'd rather put this update on hold until 0.27 has been released.

vcunat · 2018-11-26T09:19:27Z

Expected dates have been announced:

GM will be v0.27.0.0 Scheduled: 28 December 2018
RC3 will be v0.27.0.3 Scheduled: 07 November 2018

But I guess RC3 should be 07 December, given that the announcement was on 16 November :-)

Mainly run test and remove additionally installed stuff.

vcunat · 2018-12-30T09:01:02Z

Well, the real problem with 0.27 is that a large fraction of direct dependents won't build with it (yet). EDIT: too many for me to fix anytime soon and way too intrusive for 18.09 anyway.

The bump includes all the patches we had and adds some more, e.g. for CVE-2017-1000127. I don't think all CVEs get fixed by that, but 0.27 would currently break too many packages; /cc NixOS#50496.

The bump includes all the patches we had and adds some more, e.g. for CVE-2017-1000127. I don't think all CVEs get fixed by that, but 0.27 would currently break too many packages; /cc #50496. (cherry picked from commit bf7d1b5)

jtojnar · 2019-01-03T02:46:04Z

gexiv2 0.10.10 supporting exiv2 0.27 was released https://gitlab.gnome.org/GNOME/gexiv2/blob/gexiv2-0.10.10/NEWS

vcunat · 2019-01-03T09:08:06Z

Let me link ghtumb patch, too. ATM it still seems early to update, but feel free to try finding/producing patches for most of our packages.

jtojnar · 2019-02-14T12:19:24Z

pkgs/desktops/gnome-3/misc/gexiv2/default.nix

@@ -12,6 +14,14 @@ stdenv.mkDerivation rec {
    sha256 = "1vf0zv92p9hybdhn7zx53h3ia53ph97a21xz8rfk877xlr5261l8";
  };

+  patches = [
+    (fetchpatch { # should be included in the following release


gexiv2 0.10.10 is in master now.

aanderse · 2019-05-14T01:04:13Z

I happened to notice 0.27.1 was release recently: https://www.exiv2.org/whatsnew.html

exiv2: 0.26.2018.06.09 -> 0.27-rc1

bc88d15

fixes NixOS#50369

GrahamcOfBorg added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Nov 17, 2018

c0bw3b added the 1.severity: security label Nov 17, 2018

exiv2: 0.27-rc1 -> 0.27-rc2

5943775

ckauhaus mentioned this pull request Nov 26, 2018

Vulnerability roundup 52: exiv2-0.26: 3 advisories #50369

Closed

3 tasks

vcunat added 2 commits December 30, 2018 09:43

exiv2: 0.27-rc2 -> 0.27

43cf1e0

exiv2: improve expression after 0.26 -> 0.27

afb07b4

Mainly run test and remove additionally installed stuff.

vcunat added 2 commits December 30, 2018 10:11

Merge branch 'master'

adcf232

gnome3.gexiv2: fix build with exiv2-0.27

f36a2ad

GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Dec 30, 2018

vcunat mentioned this pull request Dec 30, 2018

exiv2: backport 0.27-rc1 to 18.09 #50497

Closed

9 tasks

vcunat changed the title ~~exiv2: 0.26.2018.06.09 -> 0.27-rc1~~ exiv2: 0.26.x -> 0.27.x Dec 31, 2018

jtojnar mentioned this pull request Jan 8, 2019

gexiv2: 0.10.9 -> 0.10.10 #53623

Closed

jtojnar requested changes Feb 14, 2019

View reviewed changes

infinisil added the 8.has: package (update) label Mar 30, 2019

worldofpeace self-assigned this May 20, 2019

worldofpeace mentioned this pull request May 22, 2019

exiv2: 0.26.2018.12.30 -> 0.27.1 #61853

Merged

10 tasks

worldofpeace closed this in #61853 Jul 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

exiv2: 0.26.x -> 0.27.x #50496

exiv2: 0.26.x -> 0.27.x #50496

periklis commented Nov 17, 2018

Mic92 commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

Mic92 commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

vcunat commented Nov 23, 2018

vcunat commented Nov 23, 2018

ckauhaus commented Nov 26, 2018

vcunat commented Nov 26, 2018

vcunat commented Dec 30, 2018 •

edited

jtojnar commented Jan 3, 2019

vcunat commented Jan 3, 2019

jtojnar Feb 14, 2019

aanderse commented May 14, 2019

exiv2: 0.26.x -> 0.27.x #50496

exiv2: 0.26.x -> 0.27.x #50496

Conversation

periklis commented Nov 17, 2018

Motivation for this change

Things done

Mic92 commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

Mic92 commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

GrahamcOfBorg commented Nov 17, 2018

vcunat commented Nov 23, 2018

vcunat commented Nov 23, 2018

ckauhaus commented Nov 26, 2018

vcunat commented Nov 26, 2018

vcunat commented Dec 30, 2018 • edited

jtojnar commented Jan 3, 2019

vcunat commented Jan 3, 2019

jtojnar Feb 14, 2019

Choose a reason for hiding this comment

aanderse commented May 14, 2019

vcunat commented Dec 30, 2018 •

edited