Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fprintd : use correct path for read/write configuration #50478

Merged
merged 1 commit into from Nov 17, 2018
Merged

nixos/fprintd : use correct path for read/write configuration #50478

merged 1 commit into from Nov 17, 2018

Conversation

Vskilet
Copy link
Contributor

@Vskilet Vskilet commented Nov 16, 2018

Motivation for this change

Actually the service fprintd don't use correct path for write a configuration.
On ArchLinux it's the way it works https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/fprintd

It works for my T440p laptop on Nixos 18.09 on nixos-unstable channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Vskilet Vskilet mentioned this pull request Nov 16, 2018
Closed
@zimbatm
Copy link
Member

zimbatm commented Nov 16, 2018

Shouldn't the state dir be /var/lib/fprintd or it adds it's own postfix?

@Mic92
Copy link
Member

Mic92 commented Nov 16, 2018

It adds a postfix: https://gitlab.freedesktop.org/libfprint/fprintd/blob/master/src/Makefile.am#L17

@Mic92
Copy link
Member

Mic92 commented Nov 16, 2018

@GrahamcOfBorg build fprintd

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fprintd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fprintd

Partial log (click to expand)

shrinking /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/bin/fprintd-enroll
shrinking /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/bin/fprintd-verify
shrinking /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/lib/security/pam_fprintd.so
shrinking /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/libexec/fprintd
gzipping man pages under /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/lib  /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/libexec  /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0/bin
patching script interpreter paths in /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0
checking for references to /build in /nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0...
/nix/store/25s3hf6cg5rgczp4lmlhsyvzr903xn9s-fprintd-0.8.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fprintd

Partial log (click to expand)

shrinking /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/bin/fprintd-verify
shrinking /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/bin/fprintd-list
shrinking /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/bin/fprintd-delete
shrinking /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/bin/fprintd-enroll
shrinking /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/lib/security/pam_fprintd.so
gzipping man pages under /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/lib  /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/libexec  /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0/bin
patching script interpreter paths in /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0
checking for references to /build in /nix/store/m97h19n7yn9h025di8xn1sjm7dqx0i6c-fprintd-0.8.0...

@lheckemann lheckemann merged commit ff15da0 into NixOS:master Nov 17, 2018
@lheckemann
Copy link
Member

Oops, I was a bit hasty on the merge there — the commit message doesn't include fprintd as it should. Oh well, next time!

Cherry-picked to 18.09 as 3078bca.

@Vskilet Vskilet deleted the fprintd-fix branch May 1, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vskilet @zimbatm @Mic92 @GrahamcOfBorg @lheckemann