nixos: Allow passing modules in programmatically #50501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Old way: import <nixpkgs/nixos> {
configuration = {
imports = [ ./base-node.nix ];
networking.hostName = hostName;
};
}Your way: import <nixpkgs/nixos> {
configuration = ./base-node.nix;
modules = [{ networking.hostName = hostName; }];
}Which is the same as: import <nixpkgs/nixos> {
modules = [
./base-node.nix
{ networking.hostName = hostName; }
];
}So we could get rid of the import <nixpkgs/nixos> {
configuration = [
./base-node.nix
{ networking.hostName = hostName; }
];
}But really, that's pretty much the same length as the old way, so this change doesn't seem justified. |
|
That's supposed to work..? I was certain the 'configuration' parameter had to be a path, but apparently not. Oh well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As it says.
For instance, I have a piece of code that creates a large number of VMs, which differ only in their networking.hostName.
While wrapping 'configuration' does work, adding this parameter vastly simplifies said code, while minimizing coupling; it reduces to
nixos { configuration = ./base-node.nix; modules = [{ networking.hostName = hostName; }]; }.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)