Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] curl: 7.61.0 -> 7.62.0 #50479

Merged
merged 2 commits into from Nov 23, 2018
Merged

[18.09] curl: 7.61.0 -> 7.62.0 #50479

merged 2 commits into from Nov 23, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 16, 2018 •
edited

Motivation for this change

Backport of #49514

https://curl.haxx.se/changes.html#7_62_0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

NeQuissimus and others added 2 commits November 16, 2018 23:45
@NeQuissimus @c0bw3b
curl: 7.61.0 -> 7.61.1
aff3b08 
(cherry picked from commit 16650af)
@dtzWill @c0bw3b
curl: 7.61.1 -> 7.62.0
5d07a32 
See
NixOS#49463 (comment)

(cherry picked from commit e9d6475)
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/k4rmbjx86cxs4g2f20wp3jhpyhbxghaf-curl-7.62.0-man
checking for references to /build in /nix/store/k4rmbjx86cxs4g2f20wp3jhpyhbxghaf-curl-7.62.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/ydgvlml8hf3f774qg3camjwj94mwi20w-curl-7.62.0-devdoc
gzipping man pages under /nix/store/ydgvlml8hf3f774qg3camjwj94mwi20w-curl-7.62.0-devdoc/share/man/
patching script interpreter paths in /nix/store/ydgvlml8hf3f774qg3camjwj94mwi20w-curl-7.62.0-devdoc
checking for references to /build in /nix/store/ydgvlml8hf3f774qg3camjwj94mwi20w-curl-7.62.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/a21rqn2cq3m7b3acdxh5fb61691n9xkq-curl-7.62.0-debug
patching script interpreter paths in /nix/store/a21rqn2cq3m7b3acdxh5fb61691n9xkq-curl-7.62.0-debug
checking for references to /build in /nix/store/a21rqn2cq3m7b3acdxh5fb61691n9xkq-curl-7.62.0-debug...
/nix/store/wk2sw9zlhxlfq4c8msggm91iw78lkdwx-curl-7.62.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/mwy1zd9x0k22acqa87b95s4p3py48ck8-curl-7.62.0-man
checking for references to /build in /nix/store/mwy1zd9x0k22acqa87b95s4p3py48ck8-curl-7.62.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/c7sfdlkihgr0azdca605sgl0s734hxn9-curl-7.62.0-devdoc
gzipping man pages under /nix/store/c7sfdlkihgr0azdca605sgl0s734hxn9-curl-7.62.0-devdoc/share/man/
patching script interpreter paths in /nix/store/c7sfdlkihgr0azdca605sgl0s734hxn9-curl-7.62.0-devdoc
checking for references to /build in /nix/store/c7sfdlkihgr0azdca605sgl0s734hxn9-curl-7.62.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/bdz355k7wa4c5dndz33gv95xflvj6jcv-curl-7.62.0-debug
patching script interpreter paths in /nix/store/bdz355k7wa4c5dndz33gv95xflvj6jcv-curl-7.62.0-debug
checking for references to /build in /nix/store/bdz355k7wa4c5dndz33gv95xflvj6jcv-curl-7.62.0-debug...
/nix/store/kn6n6l4dz9aigcbdymgi4x33xm60b6nn-curl-7.62.0-bin

vcunat
vcunat approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only bugfixes, but probably OK.

@vcunat vcunat merged commit 5d07a32 into NixOS:staging-18.09 Nov 23, 2018
@c0bw3b c0bw3b deleted the sec/1809/curl branch November 23, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@c0bw3b @GrahamcOfBorg @vcunat @timokau @NeQuissimus @dtzWill