ibus-table-chinese: init at 1.8.2 #50475
Merged
+69
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2018 15:54
It uses /usr/share as a default parameter, which errors out on NixOS. This replaces it with the path to the derivation.
GrahamcOfBorg
added
8.has: package (new)
|
@GrahamcOfBorg build ibus-engines.table-chinese |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: ibus-engines.table-chinese Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: ibus-engines.table-chinese Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ibus-engines.table-chinese Partial log (click to expand)
|
Ma27
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
I checked this with the following VM declaration:
{
vmtest = { pkgs, ... }: {
services.xserver = {
enable = true;
desktopManager.gnome3.enable = true;
desktopManager.xterm.enable = false;
};
users.extraUsers.vm = {
isNormalUser= true;
password = "vm";
};
virtualisation.memorySize = 2048;
i18n.inputMethod.enabled = "ibus";
i18n.inputMethod.ibus.engines = [ pkgs.ibus-engines.table-chinese ];
};
}Thanks for the addition!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ibus-table-chinese adds support for several Chinese IMEs in ibus, including Wubizixing.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)