Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minishift: add openshift input #50477

Merged
merged 2 commits into from Nov 17, 2018
Merged

Conversation

calbrecht
Copy link
Member

Motivation for this change

minishift depdends on oc to control the openshift installation.
If openshift is not present, minishift tries to download openshift into cache and fails executing it because of wrong interpreter.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

minishift depdends on oc to control the openshift installation.
@fpletz fpletz merged commit 617132e into NixOS:master Nov 17, 2018
@fpletz fpletz deleted the minishift-openshift branch November 17, 2018 07:33
@c0bw3b c0bw3b mentioned this pull request Nov 25, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants