Skip to content

Conversation

@Dune-jr
Copy link
Member

@Dune-jr Dune-jr commented Nov 17, 2018

No description provided.

@LordSk
Copy link
Member

LordSk commented Nov 17, 2018

Related #1685.
Double clicking on the server-info part used to connect you to the server, acting like a big button (quite useful in my opinion).
With this change, the first click will close the server-info and the second click will connect you to the server below it (depending on mouse position).

@Dune-jr
Copy link
Member Author

Dune-jr commented Nov 17, 2018

Double click still works to connect

Ah, nevermind. I can see the problem, yeah. A fix would be to only trigger this "fold" behavior when the line is clicked, not when the server details are.

@oy
Copy link
Member

oy commented Nov 18, 2018

Hm, not sure about it. Maybe provide that feature via an icon so it feels more intuitive.

@Dune-jr
Copy link
Member Author

Dune-jr commented Nov 18, 2018

A small - on a corner of the expanded server maybe?

I feel like this feature is a bit niche, wouldn't want to clutter anything with it, keep it discreet.

@Dune-jr
Copy link
Member Author

Dune-jr commented Nov 19, 2018

I did not find a way to squeeze in a (-) to fold the entry, as the top left corner is used to display the password icon, and I wouldn't want to move anything much for a niche feature.

@oy oy merged commit b9ea02d into teeworlds:master Nov 19, 2018
@Dune-jr Dune-jr deleted the feature-refoldonclick branch November 22, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

3 participants