Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 6d8953ba082b
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 80738ed9dc0c
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 17, 2018

  1. nixos gtk.iconCache.enable: default from xserver.enable 

    It's a quick approximation to unblock unstable channels after #48116.
This commit isn't ideal, as I suspect most wayland users won't have
xserver.enable, so they will lose the icon cache in case they had gtk
in system path (otherwise they didn't get cache anyway).

I considered using environment.noXlibs, but the nixos tests installing
headless systems do *not* get that option, so we would still be pulling
gtk in many cases where it's clearly not desired.  We need to design
this more carefully.
    @vcunat
    vcunat committed Nov 17, 2018
    Copy the full SHA
    80738ed View commit details
    Browse the repository at this point in the history