-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
trivial: random fixes #50491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trivial: random fixes #50491
Conversation
Old link no longer works. There're other broken patches in that file, but I was too lazy to investigate where one can download them now.
Debian's anonscm is dead, they use a Gitlab instance now.
Debian's anonscm is dead, they use a Gitlab instance now. The hash changed because the branch was rebased upstream, the diff is a noop.
@GrahamcOfBorg build vlc |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: vlc Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: vlc Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: vlc Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: cmake_2_8, datefudge, mdf2iso, mr, vlc Partial log (click to expand)
|
@GrahamcOfBorg build cmake_2_8 datefudge mdf2iso mr |
Success on aarch64-linux (full log) Attempted: cmake_2_8, datefudge, mdf2iso, mr Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: cmake_2_8, datefudge, mdf2iso, mr Partial log (click to expand)
|
vlc is fat on deps, but I built both versions (with and without qt) locally, so this should be fine. The change is a noop for the default vlc config anyway. |
|
||
src = fetchgit { | ||
url = "git://myrepos.branchable.com/"; | ||
rev = "refs/tags/" + version; | ||
sha256 = "15i9bs2i25l7ibv530ghy8280kklcgm5kr6j86s7iwcqqckd0czp"; | ||
rev = "0ad7a17bb455de1fec3b2375c7aac72ab2a22ac4"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? The version is tagged.
Success on x86_64-linux (full log) Attempted: cmake_2_8, datefudge, mdf2iso, mr, vlc Partial log (click to expand)
|
So that the hash won't change if the tag moves again. |
If they move their tags you should probably add that as a comment. Pretty ironic that some project that has to do with version control moves the git tags. |
The tag was moved, the diff is fine.
else building via e.g. `python3Packages.gpgme` produces the wrong result.
3367ffe
to
ac09051
Compare
Added a comment. |
Failure on aarch64-linux (full log) Attempted: cmake_2_8, datefudge, mdf2iso, mr, vlc Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: cmake_2_8, datefudge, mdf2iso, mr, vlc Partial log (click to expand)
|
Looks like vlc never worked on aarch64. We should always fix those cases when we see them. Can you please add a commit disabling the aarch64 platform for the relevant dependency? |
No it has worked in the past. |
Oh thats good. I assumed the trunk job would show all past builds. |
See commit messages.