Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smlnj: 110.79 -> 110.84 #50489

Merged
merged 3 commits into from
Dec 1, 2018
Merged

smlnj: 110.79 -> 110.84 #50489

merged 3 commits into from
Dec 1, 2018
+30 −29

Conversation

nalbyuites
Copy link
Contributor

@nalbyuites nalbyuites commented Nov 17, 2018 •
edited
Loading

Motivation for this change

Newer binary required for https://www.coursera.org/learn/programming-languages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@nalbyuites
smlnj: 110.79 -> 110.84 and smlnj-bootstrap: 110.80 -> 110.84
c8115bd
@nalbyuites
smlnj: 110.84 includes a new implementation of Abstract Syntax Descri…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
273aa1f 
…ption Library (ASDL). Adding it as a required source.
@nalbyuites nalbyuites changed the title smlnj 110.79 -> 110.84 smlnj: 110.79 -> 110.84 Nov 17, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 17, 2018

@GrahamcOfBorg build smlnj

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: smlnj

Partial log (click to expand)

Cannot nix-instantiate `smlnj' because:
error: i686 Linux package set can only be used with the x86 family.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: smlnj

Partial log (click to expand)

  "start", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture i386
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [makefile:375: gen-sizes] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-smlnj-110.84.drv-0/base/runtime/objs'
make: *** [mk.x86-darwin:52: all] Error 2
./config/install.sh: !!! Run-time system build failed for some reason.
builder for '/nix/store/h1917f8vimnw2lza61b3s1dzag3ch0gl-smlnj-110.84.drv' failed with exit code 1
error: build of '/nix/store/h1917f8vimnw2lza61b3s1dzag3ch0gl-smlnj-110.84.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: smlnj

Partial log (click to expand)

/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/.run-sml: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/ml-nlffigen: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/ml-lex: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/.link-sml: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/.arch-n-opsys: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/ml-build: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/sml: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/ml-antlr: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
/nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84/bin/ml-yacc: interpreter directive changed from "/bin/sh" to "/nix/store/9141n7v9la8kk8flzsnkzsvqlsd8wxia-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/hk4asg6yqfa94c86bmd988jgf2yqkqvf-smlnj-110.84...

@Mic92
Copy link
Member

Mic92 commented Nov 17, 2018 •
edited
Loading

@jwiegley do you know why it tries to build on aarch64-linux at all? The darwin build was also broken before.

@Mic92
Copy link
Member

Mic92 commented Nov 17, 2018

This package is failing now:

@GrahamcOfBorg build manticore

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: manticore

Partial log (click to expand)

Cannot nix-instantiate `manticore' because:
error: while evaluating the attribute 'buildInputs' of the derivation 'manticore-2017.08.22' at /var/lib/gc-of-borg/nix-test-rs-11/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-11/pkgs/stdenv/generic/make-derivation.nix:180:11:
while evaluating 'getOutput' at /var/lib/gc-of-borg/nix-test-rs-11/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-11/lib/attrsets.nix:455:23, called from undefined position:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-11/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-11/pkgs/stdenv/generic/make-derivation.nix:128:17, called from undefined position:
i686 Linux package set can only be used with the x86 family.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: manticore

Partial log (click to expand)

     implicit entry/start for main executable
ld: symbol(s) not found for architecture i386
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [makefile:375: gen-sizes] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-smlnj-110.84.drv-0/base/runtime/objs'
make: *** [mk.x86-darwin:52: all] Error 2
./config/install.sh: !!! Run-time system build failed for some reason.
builder for '/nix/store/h1917f8vimnw2lza61b3s1dzag3ch0gl-smlnj-110.84.drv' failed with exit code 1
cannot build derivation '/nix/store/vq482xippldzbv7q4bar16g48hqc8y4k-manticore-2017.08.22.drv': 1 dependencies couldn't be built
error: build of '/nix/store/vq482xippldzbv7q4bar16g48hqc8y4k-manticore-2017.08.22.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: manticore

Partial log (click to expand)

  actual: int -> Label.label
Error: Compiler bug: ModuleUtil: getStr: bad entity
Compilation failed.
make[2]: *** [Makefile:83: pmlc.x86-linux] Error 1
make[2]: Leaving directory '/nix/store/5zy5w8jjm8vzaqjhhqpn9z7mpncmk01m-manticore-2017.08.22/repo_checkout/src/tools/mc'
make[1]: *** [Makefile:39: build] Error 2
make[1]: Leaving directory '/nix/store/5zy5w8jjm8vzaqjhhqpn9z7mpncmk01m-manticore-2017.08.22/repo_checkout/src'
make: *** [Makefile:58: build] Error 2
builder for '/nix/store/g21hjshf6pha15fdqmg6k34id718gijn-manticore-2017.08.22.drv' failed with exit code 2
error: build of '/nix/store/g21hjshf6pha15fdqmg6k34id718gijn-manticore-2017.08.22.drv' failed

@jwiegley
Copy link
Contributor

@jwiegley do you know why it tries to build on aarch64-linux at all? The darwin build was also broken before.

No, I don't.

@nalbyuites
Copy link
Contributor Author

@Mic92 Is there anything else I need to do here or will Hydra pick this up eventually and it will be available on the binary cache?

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

@nalbyuites it will be only picked up by hydra, when it is merged.
Can you have a look at manticore. This got broken by the update.

@nalbyuites
Copy link
Contributor Author

@Mic92 I will take a look at manticore. Could you please let me know which jobset to look under here to find the job that failed?

@nalbyuites
Copy link
Contributor Author

@Mic92 My bad. I realized that I could do nix-build -A manticore on my branch locally and I was able to reproduce the build failure. Looking into it.

@veprbl veprbl added the 2.status: work-in-progress This PR isn't done label Nov 28, 2018
@nalbyuites nalbyuites mentioned this pull request Dec 1, 2018
Closed
@nalbyuites
Copy link
Contributor Author

nalbyuites commented Dec 1, 2018 •
edited
Loading

@Mic92 As pointed out by manticore developer @kavon, newer SML/NJ does not work is because of a change in MLRISC, which is part of SML/NJ, that was made in SML/NJ 110.81.

I have asked him to ratify if the latest manticore revision is stable enough to use.

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2018

@GrahamcOfBorg build manticore

@nalbyuites
Copy link
Contributor Author

Manticore: 2018-09-29 (revision 47273c463) is good to go.

@Mic92 Mic92 merged commit 90f0a7c into NixOS:master Dec 1, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 1, 2018

Thanks!

@nalbyuites nalbyuites deleted the smlnj-110_84 branch December 2, 2018 08:51
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nalbyuites @Mic92 @GrahamcOfBorg @jwiegley @veprbl @Janik-Haag