Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.async_generator: fix build on python3.5 #50285

Merged
merged 1 commit into from Nov 29, 2018
Merged

python3Packages.async_generator: fix build on python3.5 #50285

merged 1 commit into from Nov 29, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 12, 2018

Motivation for this change

fixes #50271

async_generator is supported on python3.5 https://pypi.org/project/async_generator/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner November 12, 2018 21:46
@marsam marsam force-pushed the feature/async_generator-python35 branch from 9dc3f7a to ceec64f Compare November 12, 2018 21:51
@costrouc
Copy link
Member

costrouc commented Nov 12, 2018 •
edited

This is not the problem. The issue is a circular dependency that the checkPhase of async_generator requires pytest-asyncio. pytest-asyncio requires async_generator if python_version == 3.5.

My suggestion is that tests should be disabled for async_generatorif python version == 3.5. Additionally pytest-asyncio needs to add async_generator as a propagatedBuildInputif version == 3.5. This can be done usinglib.optionals isPy35`.

@marsam marsam force-pushed the feature/async_generator-python35 branch 2 times, most recently from b719233 to 4ae8ae1 Compare November 12, 2018 23:14
@marsam
Copy link
Contributor Author

marsam commented Nov 12, 2018

@costrouc you are right. I've updated the PR with your suggestion, thanks!

@costrouc
Copy link
Member

Looks good to me!

@costrouc
Copy link
Member

@GrahamcOfBorg build python35Packages.async_generator

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python35Packages.async_generator

Partial log (click to expand)

Installing collected packages: async-generator
Successfully installed async-generator-1.10
/build/async_generator-1.10
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qc8cpb75cf3j2bl6h5jr0da5qx8h68lh-python3.5-async_generator-1.10
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qc8cpb75cf3j2bl6h5jr0da5qx8h68lh-python3.5-async_generator-1.10/lib
patching script interpreter paths in /nix/store/qc8cpb75cf3j2bl6h5jr0da5qx8h68lh-python3.5-async_generator-1.10
checking for references to /build in /nix/store/qc8cpb75cf3j2bl6h5jr0da5qx8h68lh-python3.5-async_generator-1.10...
/nix/store/qc8cpb75cf3j2bl6h5jr0da5qx8h68lh-python3.5-async_generator-1.10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python35Packages.async_generator

Partial log (click to expand)

Processing ./async_generator-1.10-py3-none-any.whl
Installing collected packages: async-generator
Successfully installed async-generator-1.10
/build/async_generator-1.10
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vv6nhd0l8yn55xqkffvg6f2jizv3ppb0-python3.5-async_generator-1.10
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vv6nhd0l8yn55xqkffvg6f2jizv3ppb0-python3.5-async_generator-1.10/lib
patching script interpreter paths in /nix/store/vv6nhd0l8yn55xqkffvg6f2jizv3ppb0-python3.5-async_generator-1.10
checking for references to /build in /nix/store/vv6nhd0l8yn55xqkffvg6f2jizv3ppb0-python3.5-async_generator-1.10...

@marsam marsam force-pushed the feature/async_generator-python35 branch from 4ae8ae1 to aa8ff56 Compare November 20, 2018 17:35
@worldofpeace worldofpeace changed the title python3Packages.async_generator: enable in python3.5 python3Packages.async_generator: fix build on python3.5 Nov 29, 2018
@worldofpeace
Copy link
Contributor

Does what it says on the tin 😉 merging.

@worldofpeace worldofpeace merged commit 8d88e4f into NixOS:master Nov 29, 2018
@marsam marsam deleted the feature/async_generator-python35 branch November 29, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async_generator: not available for python35
4 participants
@marsam @costrouc @GrahamcOfBorg @worldofpeace