Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flex_2_6_1: delete in favor of flex 2.6.4 #50292

Merged
merged 1 commit into from Nov 13, 2018
Merged

flex_2_6_1: delete in favor of flex 2.6.4 #50292

merged 1 commit into from Nov 13, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 13, 2018

Motivation for this change

There is no need for flex_2_6_1: its last user nas builds with flex, currently at 2.6.4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej-nixos orivej-nixos merged commit 5b4044a into NixOS:master Nov 13, 2018
@orivej
Copy link
Contributor Author

orivej commented Nov 13, 2018 •
edited

Could you show how collectd needs flex_2_6_1? collectd 5.8.1 from the archive (without generated files) seems to build fine with flex.

@orivej orivej deleted the flex branch March 29, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @orivej-nixos