Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidsdk: fix emulator #50276

Merged
merged 2 commits into from Nov 12, 2018
Merged

androidsdk: fix emulator #50276

merged 2 commits into from Nov 12, 2018

Conversation

corngood
Copy link
Contributor

Motivation for this change

See #49515, #50263

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@corngood corngood mentioned this pull request Nov 12, 2018
Closed
@corngood
Copy link
Contributor Author

I've been using the emulator successfully for a couple of days, but more testing would be appreciated.

@Mic92 Mic92 merged commit 968b20e into NixOS:master Nov 12, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 12, 2018

I guess we can merge this for now if it is an improvement over the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corngood @Mic92 @GrahamcOfBorg @clefru