Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyopenssl: Disable flaky test_wantWriteError test. #50294

Closed
wants to merge 1 commit into from
Closed

pyopenssl: Disable flaky test_wantWriteError test. #50294

wants to merge 1 commit into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 13, 2018

Works around pyca/pyopenssl#768

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nh2 nh2 requested a review from FRidh as a code owner November 13, 2018 02:40
@nh2
Copy link
Contributor Author

nh2 commented Nov 13, 2018

CC @dtzWill from #42180 (comment)

@FRidh FRidh changed the base branch from master to staging July 20, 2019 11:39
@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

Needs a rebase. Please reopen if interested in getting this in. I think it's fine.

@FRidh FRidh closed this Jul 20, 2019
@nh2
Copy link
Contributor Author

nh2 commented Jul 20, 2019

@FRidh Rebased, reopening

@nh2
Copy link
Contributor Author

nh2 commented Jul 20, 2019

@FRidh I clicked Reopen and comment but it only commented; it's still marked as Closed and now the Reopen and comment button is permanently greyed out.

@nh2 nh2 mentioned this pull request Jul 20, 2019
Merged
@nh2
Copy link
Contributor Author

nh2 commented Jul 20, 2019

Looks like a Github bug to me, so I made a new one in #65160 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @FRidh @GrahamcOfBorg